Fail closed when timing.json start/end are not JSON numbers - #134
Merged
Conversation
Word and segment rows used float(row.get("start", 0.0)), so a missing start
waited until t=0 and dumped the board, and start: true became 1.0s.
Co-authored-by: jmjava <jmjava@gmail.com>
ruff, pytest (766 passed, 1 skipped), and docgen benchmark all green. Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #127 typed
words/segmentsas arrays of objects. Each row still usedfloat(row.get("start", 0.0)).startwaited until0.0and dumped the board.start: truebecame1.0becauseboolis a subclass ofint."0.5"looked like a timestamp instead of a type error.load_bundle_timingnow requiresstartandendto be JSON numbers (intorfloat, notbool). Manim_load_timing/_load_timing_wordsdo the same, andscene-compilerefreshes object-only helper bodies.Empty
[]/ missing / null lists stay allowed.Test plan
start/endfail closed; helpers refreshruff check src/ tests/pytest tests/— 766 passed, 1 skippeddocgen benchmark— meetssrc/docgen/benchmark_data/baseline.json(helper change, no--update-baseline)Milestone:
milestones/timing-start-end.md