Fail closed when ffprobe duration probes exit nonzero - #135
Merged
Conversation
Probes used float(stdout) without checking returncode. Image compose stripped an empty -t and muxed a looping still without a finite duration. Co-authored-by: jmjava <jmjava@gmail.com>
ruff, pytest (770 passed, 1 skipped), and docgen benchmark all green. Co-authored-by: jmjava <jmjava@gmail.com>
Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 23:55
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Duration probes in compose / TTS / validate / local timestamps ran ffprobe without checking
returncode, thenfloat(stdout). A failed probe that still printed a number looked like a real duration._compose_imagetreated a missing duration as-t ""and stripped it, so a looping still was muxed without a finite-t.Manim/simple compose still SKIPs when both probes fail (CLI / pipeline still fail if composed < mapped).
Test plan
ruff check src/ tests/pytest tests/— 770 passed, 1 skippeddocgen benchmark— meetssrc/docgen/benchmark_data/baseline.json(no--update-baseline)Milestone:
milestones/ffprobe-returncode.md