Fail closed when generate-all visual-sync checks fail - #156
Merged
Conversation
generate-all shares run_pre_push; av_sync and the other visual-sync gates must stop Pipeline complete instead of warning. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate-allalready calledrun_pre_push. The hole was thatav_sync,subject_beat_coverage,ocr_scan,layout, andfreeze_ratiowereWARN, so a desynced mux could still printPipeline complete.FAIL+SystemExit(1)). Onlyrecording_existsstays soft so ungenerated bundles remain pushable.test_pipeline_av_sync_fail_stops_completedrives realrun_pre_pushwith oneav_syncpassed=False. It must not printPipeline completeand must skip concat/pages.Leftover #2 / T-D03 from the 2026-09-10 impact list. Did not start leftover #150 factory-loop hunt. No clock/compile/
_TimedScenechanges;baseline.jsonnot bumped.Test plan
test_pipeline_av_sync_fail_stops_complete—SystemExit(1), noPipeline complete, no concat/pagestest_run_pre_push_visual_sync_fail_is_hard— av_sync / subject_beat / ocr / layout / freeze print FAIL not WARNtest_run_pre_push_missing_recording_stays_softandtest_cli_validate_pre_push_missing_recording_is_softstill exit 0ruff checkon the touched filesMade with Cursor