Fail closed when harness pass@end is zero - #18
Merged
Conversation
Printed rows are not a pass; the same stub sabotage can now redden the CI stub MCP steps. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/run_harness.pynow exits non-zero whenpass@endis 0 (or below--min-pass-end). Printed rows are not a pass; the table still prints.tests/test_harness_exit.py: refuse-every-call → harness exit != 0, plus a lock that those CI steps callrun_harness.pywithoutcontinue-on-error.Q-SLM-20 leftovers 1 and 2 only. No live pass rate is claimed.
Test plan
PYTHONPATH=src .venv/bin/python -m unittest discover -s tests -v(115 tests)LOCAL_CODING_SLM_STUB_REFUSE=1) on golden--case whitespace_extractexits non-zero and printspass@end=0.00--orchestrate --job mcp_extract_acceptexits 1Made with Cursor