Repository navigation
feat(featurescript): cut holes with std's extrude locally, on opencascade - #129
Merged
Merged
Conversation
AadiJo
force-pushed
the
featurescript-geometry
branch
from
October 25, 2026 16:54
be3c6f5 to
f49a452
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AadiJo
force-pushed
the
featurescript-interpreter
branch
from
October 30, 2026 17:20
cfc867c to
b626cfb
Compare
AadiJo
force-pushed
the
featurescript-geometry
branch
from
October 30, 2026 17:20
f49a452 to
1c4d37c
Compare
AadiJo
force-pushed
the
featurescript-interpreter
branch
from
October 30, 2026 17:38
b626cfb to
be0a0b2
Compare
…ith a bolt circle e2e
AadiJo
force-pushed
the
featurescript-geometry
branch
from
October 30, 2026 17:38
1c4d37c to
1af9be7
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A local preview has to produce geometry. This adds a geometry layer on OpenCascade (WASM) so std's own modeling features run locally, starting with what a typical "cut holes into a face" script needs.
src/geometry/Model.tskeeps a topology registry. Every body, face, edge and vertex gets a transient id that survives operations through OpenCascade's history, records the feature that created it (whatqCreatedByanswers), and carries attributes. State is immutable, so std's feature rollback stays cheap. Seam edges and full-circle vertices are left out, so topology counts match Onshape's.opExtrude,opBoolean,opDeleteBodies,evPlane, attributes, and the query types std's extrude path uses. Std'sfCuboidandextruderun unmodified.corpus/<case>/case.json) are the gate:test/corpus.e2e.test.tsruns each one, checks statuses, volumes and topology counts, and writes a PNG, GLB and JSON report to.cadsense/fs-corpus/<case>/.Stacked on #128.
Testing:
vp test runinpackages/featurescript, 333 tests. The bolt circle case cuts six 5 mm holes through a 100 x 60 x 10 mm plate through std's realextrude. The volume matches the analytic 58821.9028 mm³ and the counts are 12 faces, 24 edges and 8 vertices, in about 80 ms. Geometry tests cover rollback of a failed feature's geometry and transient ids across features.Not yet checked against Onshape recordings: plane origins from
evPlane, sketch body structure, and query result order are listed as open inFeatureScript.md.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.