Repository navigation
Conversation
…ter qEverything by body type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An agent asked to merge two FRC wiring FeatureScripts (a spline path plus a wire sweep) into one wrote a sensible
wire-run.fs, but couldn't show a wire: the local runtime didn't supportopFitSpline, and couldn't create mate connectors, the natural way to mark a motor or controller port. Every preview stopped at the spline.opFitSpline: a cubic spline through points, open or closed (a repeated first point), with start, end and inner derivatives, on OpenCascade'sGeomAPI_Interpolate. Withoutparameters, points are spaced by chord length over [0, 1], so derivatives mean what std documents. Second derivatives and a target length stop the run as unsupported rather than being ignored.opMateConnectormakes a point body of typeMATE_CONNECTORthat carries its coordinate system,evMateConnectorreturns it, andevVertexPointreads its origin, as Onshape allows. Connectors don't yet follow their owner through transforms.qBodyType(qEverything(...), ...)returned every body. std folds body types into the EVERYTHING query instead of wrapping it, and the evaluator ignored them, so "all solids" also returned sketch sheets, sketch wires and connectors. Found while testing connectors.Testing
qBodyType(qEverything(BODY), SOLID)next to a sketch counts one solid and one sheet.Stacked on #135.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.