Repository navigation
fix(web): suppress the redundant t3team 'Thinking' while the native reasoning trace is live - #295
Merged
Merged
Conversation
…easoning trace is live When the provider's own thinking trace (upstream #11784, merged in the 2026-09-17 sync) is streaming for the live turn, the timeline showed TWO 'Thinking' surfaces at once: the native trace row and the t3team working-row state word (GHE #208/#236). The state word now reads 'Working' while the trace is visible; 'working'/'writing'/'waiting' state words and the state-word mechanism are untouched. Also mock t3team-threadComposingSignal in the timeline suite: the composerDraftStore -> composing-signal -> primaryEnvironment -> catalog -> connection/runtime import cycle makes the suite unloadable under vitest's entry order on post-sync main (pre-existing, test-only fix).
johnnyelwailer
marked this pull request as ready for review
September 21, 2026 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With the 2026-09-17 upstream sync (#11784 'show provider thinking traces'), the web timeline can show two 'Thinking' surfaces at once on a live turn: the provider's native reasoning-trace row and the t3team working-row state word ('Thinking', GHE #208/#236). Owner: if native thinking already shows, the redundant 'thinking' should not show; 'working'/'writing'/etc state words are fine.
Fix
When an active activity group ends in a reasoning entry (i.e. the native trace owns the live 'Thinking' surface for the current unsettled turn), the working-row lead word resolves 'Thinking' -> 'Working'. Everything else (state-word mechanism, working/writing/waiting words, the live-activity row, the trace row) is untouched. Implemented by extending the existing row-activity context (new 'liveReasoningTrace' flag beside 'suppressLiveActivityRow') — no new parallel mechanism.
Tests
Also mocks 't3team-threadComposingSignal' in the timeline test file (test-only): the 'composerDraftStore -> composing-signal -> primaryEnvironment -> catalog -> connection/runtime' import cycle makes the whole suite unloadable under vitest entry order on post-sync main — pre-existing, independent of this fix.
Model: Nexi (Nexplore AI), harness: t3team.