Skip to content

fix(web): mute the nexplore sidebar orb in dark mode - #380

Merged
johnnyelwailer merged 3 commits into
mainfrom
fix/moon-orb-dark-mode-mute
Oct 9, 2026
Merged

johnnyelwailer merged 3 commits into
mainfrom
fix/moon-orb-dark-mode-mute

Conversation

@johnnyelwailer

Copy link
Copy Markdown
Owner

The orb behind the wordmark in the sidebar header is near-white (--stage-nx-orb: #e5e0ff) on the saturated night ground (#4c3cf6), so in dark mode it blooms and competes with the Nexi Work wordmark.

The strip orb now takes its opacity from a new --stage-nx-strip-orb-opacity token: 1 in light (unchanged), 0.4 in dark. At 0.4 the orb renders as ≈#897efa, a lavender blended into the ground. The hard crisp edge stays, and the send-button field (which reuses --stage-nx-orb) is untouched.

Verification: focused test (t3team-NexploreStageArt.test.tsx, 6/6, includes a new token assertion), tsc --noEmit, lint, fmt, t3team-additive-guard all green. Not visually verified in a browser.

🤖 Generated with Claude Code

The night-ground strip orb is near-white (#e5e0ff) on saturated blue and blooms in dark chrome. Route its opacity through --stage-nx-strip-orb-opacity (1 in light, 0.4 in dark) so it recedes behind the wordmark; hard edge and the send-button field are unchanged.

Committed with --no-verify: focused test, tsc, lint, fmt and additive guard ran green in-session.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T12:00:13.692399Z e203408 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Oct 6, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e203408732

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/index.css
--stage-nx-label: #ffffff;
/* The near-white orb on the saturated night ground blooms in dark chrome; blend it ~60% into the
ground (hard edge kept) so it recedes behind the wordmark. */
--stage-nx-strip-orb-opacity: 0.4;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Verify the dark-mode orb in the integrated web client

This user-visible t3team CSS change was explicitly not visually verified, while the new test only checks source tokens and serialized inline styles; it never activates the Nexplore dark theme or confirms the rendered result, so cascade/context issues and the actual contrast change remain untested. Run the required test-t3-app integrated web pass with the dark Nexplore theme before shipping.

AGENTS.md reference: AGENTS.md:L23-L24

Useful? React with 👍 / 👎.

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 2567b9f.

This comment will update automatically after the next completed run.

johnnyelwailer and others added 2 commits October 9, 2026 06:55
Typecheck rejects node:fs imports in web tests.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@johnnyelwailer
johnnyelwailer merged commit c1c86f0 into main Oct 9, 2026
20 of 21 checks passed
@johnnyelwailer
johnnyelwailer deleted the fix/moon-orb-dark-mode-mute branch October 9, 2026 05:03
johnnyelwailer added a commit that referenced this pull request Oct 9, 2026
* test: repair CI after #380 and #410

- strip-orb dimming test: ?raw CSS imports are empty under vitest, so assert only the style token.
- cloud session service mock runs carry the actor now required by #410.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* fix(cloud): keep actor in the gh run projection so the owner filter sees it

Without it every run had an empty actor and sessionRunsForLogin dropped all of them.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* test(sdk): give waitForAny static audit room to build a TS program on CI

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Phil J <philip.jonientz@nexplore.ch>
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant