Skip to content

Compound and collection attributes - #2104

Draft
bkoelman wants to merge 212 commits into
masterfrom
compound-attributes-and-collections
Draft

Compound and collection attributes#2104
bkoelman wants to merge 212 commits into
masterfrom
compound-attributes-and-collections

Conversation

@bkoelman

@bkoelman bkoelman commented Oct 17, 2026

Copy link
Copy Markdown
Member

Closes #{ISSUE_NUMBER}

QUALITY CHECKLIST

@codecov

codecov Bot commented Oct 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.98907% with 88 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.14%. Comparing base (61fec0b) to head (4e67194).

Files with missing lines Patch % Lines
.../Expressions/SparseFieldSetExpressionExtensions.cs 55.55% 14 Missing and 2 partials ⚠️
...e/Queries/QueryableBuilding/SelectClauseBuilder.cs 85.71% 2 Missing and 9 partials ⚠️
src/JsonApiDotNetCore/Queries/FieldSelection.cs 27.27% 7 Missing and 1 partial ⚠️
...otNetCore/Queries/Parsing/QueryExpressionParser.cs 78.94% 6 Missing and 2 partials ⚠️
.../JsonApiDotNetCore/Queries/Parsing/FilterParser.cs 96.06% 3 Missing and 4 partials ⚠️
...piDotNetCore/Configuration/ResourceGraphBuilder.cs 95.16% 2 Missing and 4 partials ⚠️
...lization/Request/Adapters/ResourceObjectAdapter.cs 92.94% 4 Missing and 2 partials ⚠️
src/JsonApiDotNetCore/Queries/FieldSelectors.cs 66.66% 4 Missing ⚠️
...c/JsonApiDotNetCore/Configuration/ResourceGraph.cs 96.51% 1 Missing and 2 partials ⚠️
...ns/Resources/Annotations/ResourceFieldAttribute.cs 80.00% 1 Missing and 1 partial ⚠️
... and 16 more
Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #2104    +/-   ##
========================================
  Coverage   92.14%   92.14%            
========================================
  Files         366      377    +11     
  Lines       12125    13017   +892     
  Branches     2038     2328   +290     
========================================
+ Hits        11173    11995   +822     
- Misses        584      644    +60     
- Partials      368      378    +10

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bkoelman
bkoelman force-pushed the compound-attributes-and-collections branch 4 times, most recently from 8afb96e to d6e6816 Compare October 20, 2026 01:33
@bkoelman
bkoelman force-pushed the compound-attributes-and-collections branch 9 times, most recently from f25a98a to be10f73 Compare October 29, 2026 23:38
@bkoelman
bkoelman force-pushed the compound-attributes-and-collections branch from f764676 to 6293895 Compare November 1, 2026 15:27
bkoelman and others added 15 commits November 1, 2026 16:27
@bkoelman @cursoragent
Drop the net9.0 and net8.0 target frameworks
33f77be 
Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman @cursoragent
Introduce IAttributeContainer interface and implement on ResourceType
fd1a965 
Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman @cursoragent
Introduce CompoundType descriptor and register in IResourceGraph
6c21fc7 
Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman @cursoragent
Update AttrAttribute with compound metadata
09a2a0b 
Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman @cursoragent
Update ResourceFieldAttribute: drop Type, add ContainingType, update …
bcf41a4 
…LeftType

Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman @cursoragent
ResourceGraphBuilder: Recursive discovery of CompoundType and children
b88548d 
Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman @cursoragent
Validate compound types and their attributes in ResourceGraphBuilder
18585b3 
Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman @cursoragent
Implement 6-token grammar (O, M, A, C, P, Q) in FieldTypes & FieldCha…
9f70c4c 
…inPattern

Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman @cursoragent
Update PatternParser and PatternTextFormatter for compound tokens
ce79bf5 
Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman @cursoragent
Update PatternMatcher and MatchState to traverse IAttributeContainer
ba0f79f 
Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman @cursoragent
Support compound attribute and collection scoping in FilterParser
cf83ab3 
Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman @cursoragent
Introduce ElementValueExpression and parse '_' in primitive collectio…
b0f1938 
…n has()

Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman @cursoragent
SortParser: Enforce [OC]*A and reject sorting on compound attributes …
ec5e840 
…or collections

Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman @cursoragent
SparseFieldSetParser: Parse hierarchical attribute chains
3925090 
Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman @cursoragent
WhereClauseBuilder: Collection Any(), Count, and ElementValueExpressi…
bbfb5eb 
…on translation

Co-authored-by: Cursor <cursoragent@cursor.com>
bkoelman and others added 29 commits November 1, 2026 16:28
@bkoelman @claude
Accept _ on the right-hand side of element comparisons again; allow n…
98e5fb6 
…ull collection elements for nullable element types

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Add adapter tests for null collection elements per element type
b44062f 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Restore rejection of _ on the right-hand side of comparisons (grammar…
adfcbae 
… rule)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Update integration tests for null collection element rules
761d39e 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Replace attribute value snapshot by JSON snapshots with private seria…
746617b 
…lizer options in change tracker

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Add integration tests for non-exposed members of compound types
08e40c9 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Apply code cleanup after round 3
d84ff4c 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Document compound attributes, collections and element scope in filtering
20cd02b 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Document nested paths and collection counts in sorting
9c70988 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Document compound selection in sparse fieldsets
5223eff 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Fix null note in sparse fieldsets docs
ecd5291 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Document compound paths and element scope for custom functions
19141e2 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Document sparse fieldset helpers, hook invocation and compound member…
005c0b6 
…s in resource definitions

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Describe compound-related query concepts in internals
b14b0ed 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Docs: compound and collection attributes
44bf30a 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Docs: nullability and resource graph for compound attributes
cc580c3 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Docs: naming policies in options
da3ba14 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Docs: creating resources with compound attributes
cb52428 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Docs: updating compound and collection attributes
f6467ea 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Docs: model validation of compound attributes
e356307 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Docs: inheritance and blobs
43fa5a3 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Docs: update compound attributes pitfall
0fdd498 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Add anchors to compound attribute links in docs
501fc9f 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Fix ReSharper issues in library code
8f7fe70 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Fix ReSharper issues in tests
4341fbb 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Fix blank lines and apply cleanup
fb72c1d 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Update numeric enum value in test after removing unused PhoneKind member
7ebf235 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Mark nullable-property enums as public API for ReSharper
fe91094 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman @claude
Reconcile tree with pre-linearization branch state
4e67194 
Conflicts while linearizing merge history were auto-resolved; this commit
restores the exact tree of the original branch tip.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bkoelman
bkoelman force-pushed the compound-attributes-and-collections branch from 6293895 to 4e67194 Compare November 1, 2026 15:28

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bkoelman