[JUJU-759] Change error types to use new ConstError - #54
Merged
Conversation
Contributor
|
Can one of the admins verify this patch? |
1 similar comment
Contributor
|
Can one of the admins verify this patch? |
Contributor
Author
|
!!build!! |
barrettj12
marked this pull request as draft
March 23, 2022 00:58
barrettj12
marked this pull request as ready for review
March 23, 2022 01:51
tlm
approved these changes
Mar 23, 2022
wallyworld
reviewed
Mar 23, 2022
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #52, this library now supports
errors.Is,errors.As, anderrors.Unwrapfrom Go's standard errors library. This PR changes theIsXfunctions fromerrortypes.goto useerrors.Isunder the hood:ConstError, whose values are "sentinel errors" representing a certain error type.errWithType, which is anErrbundled with its error typeerrType ConstError.errWithTypeimplements anIsmethod that compares its argument toerrType. This ensures e.g.Is(e, NotFound)works as expected.timeout,notFoundhave been replaced witherrWithType.X ConstError,XfandNewXnow returne errWithTypewheree.errTypeisX.IsXfunctions are now implemented by comparison toX.This is structurally quite a big change, but the errors should behave exactly as before (all the tests in
errortypes_test.gopass).