refactor: update config names - #123
Merged
SimonRichardson merged 1 commit intoJul 10, 2026
Merged
Conversation
The config names were the same as the controller config, but they're not the same as the controller now they're in the controller charm. Fixing this makes the charm feel consistent. We can do this, because we've not released the charm.
jujubot
added a commit
to juju/juju
that referenced
this pull request
Jul 9, 2026
#22813 The trace worker was unfortunately broken when we migrated to a controller only manifold. This highlighted 2 issues: 1. The HTTP endpoint didn't work on its own, only the GRPC one worked. The solution is to split them in the agent so that we can decide which client to use. As we can't guarantee the endpoint will have a schema from the charm endpoints, we can't parse it to know exactly which one is being used. 2. The non-controller trace doesn't update the url if it's added at a later date. This was because we removed agent config updater, so a new worker will be coming in a follow up PR. Lastly, along with the changes juju/juju-controller#123 in the controller charm, the prefixes have been renamed so you know exactly which config values affect what part. This makes the experience a lot more integrated. ## QA steps Deploy cos-lite, with tempo, create an offer called tempo-tracing and consume it before integrating it with the controller charm. ```sh $ juju bootstrap lxd src --bootstrap-base=ubuntu@24.04 --controller-charm-path=./juju-controller_ubuntu@24.04-amd64.charm --build-agent $ juju switch controller $ juju integrate controller:workload-tracing tempo-tracing ``` ## Links **Jira card:** [JUJU-10075](https://warthogs.atlassian.net/browse/JUJU-10075) [JUJU-10075]: https://warthogs.atlassian.net/browse/JUJU-10075?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
nvinuesa
approved these changes
Jul 10, 2026
nvinuesa
left a comment
nvinuesa
left a comment
Member
There was a problem hiding this comment.
As discussed offline, this is OK to land because all of these config were added on an unreleased version and we therefore don't break any compat.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config names were the same as the controller config, but they're not the same as the controller now they're in the controller charm.
Fixing this makes the charm feel consistent. We can do this, because we've not released the charm.