Skip to content

learn: no Windows test execution; direct-exec program model likely cannot run script tools there #257

Description

@justrach

The learn subsystem (tests/learn_e2e.py) runs only on the Linux CI job; the Windows job builds but never exercises graff learn. The store/eval code paths use direct process execution of the configured mutator/evaluator program, which on Windows cannot execute a #!-shebang python script directly: configs would need python.exe as the program with the script as an argument, or a .bat shim.

From the #246 review (confirmed finding, medium): add learn_e2e to the Windows CI job and either document the python.exe-as-program pattern or add a script-tool execution model for Windows. The pass_env deny-list already covers ComSpec/SystemRoot case-insensitively.

Activity

  1. justrach commented on Jul 24, 2026

    @justrach
    OwnerAuthor

    Shipped on main — fc7c744 gives the learn subsystem Windows E2E coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions