Skip to content

rewind/serve polish: restore-counter honesty, pin-test scope #406

Description

@justrach

Deferred minors from the reviews of fix/rewind-snapshot-read-failure and fix/serve-ultracode-ack (merged for v0.0.239).

  1. snapshots.zig restore() .content arm: a failed write-back (writeFile catch continue) is counted in neither restored nor skipped, so a /rewind whose only traffic failed prints a report that adds up to less than the files it touched. Count it (a third bucket or fold into skipped).
  2. serve_events pin test: one assertion is dead by construction (checked == typed — the scan loop is driven by the same needle it counts), and the scan only reads mainloop.zig's inline block between the markers — a control handler living in its own module (the existing score/mainloop_score.zig shape) is invisible to it and covered only by a hand-written special case. Fine today; will drift silently the next time a handler moves out of mainloop.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions