Repository navigation
fix(trace): record transport-flake retries in the session trace - #173
Merged
Merged
Conversation
The 429/5xx retry branch leaves a 'retry' trace note; the transport-flake
branch (HttpConnectionClosing, resets, truncated TLS reads) said so on
screen but wrote nothing to harness.trace.jsonl, so provider flakiness was
invisible when diagnosing a session after the fact. Leave the same
breadcrumb with the error name.
Verified against an accept-then-close socket: all 6 flake retries now show
as {ev:retry, detail:HttpConnectionClosing} with backoff-spaced timestamps.
Co-Authored-By: blackfloofie <265516171+blackfloofie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One breadcrumb: the transport-flake retry branch (
HttpConnectionClosing, resets, truncated TLS reads) now leaves the same{ev:"retry", detail:<error>}note inharness.trace.jsonlthat the 429/5xx branch already leaves.Why
A flaky provider was invisible in the session trace — the retries printed to the screen but left no trace record, so post-hoc diagnosis of a slow/flaky session couldn't see how many transport retries a turn ate.
Verification
Pointed graff at an accept-then-close socket: all 6 flake retries appear as
{ev:retry, detail:HttpConnectionClosing}with backoff-spaced timestamps (41ms, 318ms, 851ms, 1.9s, 4.1s, 8.4s).zig build+zig build testclean.