Repository navigation
fix(ci): Linux O_PATH dir-chmod panic + stale max_output_tokens PTY assertions - #254
Merged
Merged
Conversation
On Linux, a default openDir can yield an O_PATH handle; fchmod on O_PATH
fails EBADF, which std.Io (0.17-dev) escalates to a programmer-bug panic
that catch {} cannot swallow. The kimi catalog hydration added in 7e08374
made this reachable mid-session: once ~/.kimi/device_id exists, any
/model query that may use kimi re-enters initIdentity -> secureDir and the
process panics (seen as the JSON live-control test losing all events after
'set_model provider/model keyless' on Linux CI; macOS never hit it because
its dir handles are always chmod-able).
Co-Authored-By: Codegraff <blackfloofie@codegraff.com>
…utput_tokens The midturn/transactional scenarios still expected explicit 16k/4k/16k top-level output caps, but #247 removed the field entirely (gpt-5.6 rejects it). CI never caught the stale expectation because the json-controls step failed first and the job stopped. Assert the new contract: the field must be absent from every Responses request. Co-Authored-By: Codegraff <blackfloofie@codegraff.com>
…st (#247) Co-Authored-By: Codegraff <blackfloofie@codegraff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main's zig CI job has been red since 7e08374, but the first failure masked two more behind it (the job stops at the first failed step):
JSON live-control test (Linux-only panic): the kimi catalog hydration added in 7e08374 made
kimi_catalog.secureDirreachable mid-session. A defaultopenDircan yield an O_PATH handle on Linux, andfchmodon O_PATH fails EBADF — which std.Io (0.17-dev) escalates to a programmer-bug panic thatcatch {}cannot swallow. Once~/.kimi/device_idexists, any/modelquery that may use kimi re-entersinitIdentity → secureDirand the process dies (the test sees stdout EOF after the 8th event). macOS never hit it: its dir handles are always chmod-able. Fix: open with.iterate = truein bothkimi_catalog.secureDirand the identicaloauth.zigkimi-credentials loop.Codex WS/SSE transport test:
test-pty-codex-ws.pystill asserted explicit top-level 16k/4k/16kmax_output_tokenscaps, but fix(codex): drop top-level max_output_tokens from Responses requests #247 intentionally dropped the field (gpt-5.6 rejects it). Assert its absence instead.Title-parallel test: same stale caps assertion, same fix.
Validation
debug/json-controls-main) with these exact commits: full CI green (run 29715398686)zig build test231/231,test-json-controls.py19/19,test-pty-codex-ws.py6/6 scenarios,test-title-parallel.pyokCo-Authored-By: Codegraff blackfloofie@codegraff.com