fix(tui): expand tabs at paint time so the screen matches the frame - #561
Draft
justrach wants to merge 1 commit into
Draft
fix(tui): expand tabs at paint time so the screen matches the frame#561justrach wants to merge 1 commit into
justrach wants to merge 1 commit into
Conversation
Tab was counted as one column and written raw, so pad() left residue or overflowed once the emulator advanced to the next stop of 8. Measure and write now agree; a hover row the frame no longer reaches clears instead of staying armed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last paint hole after the C0 fix: a tab was counted as one column and written raw, so
pad()left residue (or overflowed) once the emulator jumped to the next stop of 8.paintRownow expands tabs to spaces at measure and write time. SGR stays; other C0 still drops. A hover row the frame no longer reaches clears instead of staying armed.zig build tui-test -Dtest-filter="paint"48/48; hover 31/31.