P0lskay/issue182 Add support for customizable labels on Vector resources#185
Merged
Conversation
Collaborator
|
Thank you for the pull request! I've reviewed it and everything looks good. Maybe we could create a separate function for adding labels? Something like this: We could save it here, for example: |
Contributor
Author
|
@dkhachyan Great idea, thanks! I have already added the function of merging labels in commit 187e41b. If it's ok, then I think we can merge this PullRequest. |
Fixes kaasops#182 Update labels definition for all resources Fixes kaasops#182 Update manifests and code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations Update documentation Add individual method for matchLabels Update description for labels field in CRDs Fix specification.md Update CRDs in helm chart Create new function MergeLabels for merging of labels :)
3eee821 to
e08e31b
Compare
zvlb
pushed a commit
that referenced
this pull request
May 28, 2026
P0lskay/issue182 Add support for customizable labels on Vector resources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: #182
Changes: