Skip to content

fix: reconcile aggregator PDB last to not block HPA on failure - #231

Merged
aa1ex merged 1 commit into
kaasops:mainfrom
aa1ex:fix/aggregator-pdb-order-and-tests
Jul 2, 2026
Merged

fix: reconcile aggregator PDB last to not block HPA on failure#231
aa1ex merged 1 commit into
kaasops:mainfrom
aa1ex:fix/aggregator-pdb-order-and-tests

Conversation

@aa1ex

@aa1ex aa1ex commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #229.

The PDB step ran before the event collector and HPA steps, so a rejected PDB write (admission policy, quota, RBAC) aborted the reconcile and left the aggregator without autoscaling until the write recovered. Now it runs last; the failure is still reported and retried. Verified on a live cluster with an admission policy denying PDB writes: the HPA is created while the PDB retries.

Along the way: field docs now state that minAvailable wins when both minAvailable and maxUnavailable are set (CRDs regenerated, helm mirrored), and unit tests for the PDB and HPA reconcile gates plus a regression test for the new ordering. To make the gates testable, Controller.ClientSet and configcheck.New take kubernetes.Interface now; callers are unchanged.

@aa1ex aa1ex self-assigned this Jul 2, 2026
@aa1ex
aa1ex merged commit fb76dee into kaasops:main Jul 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant