fix: reconcile aggregator PDB last to not block HPA on failure - #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #229.
The PDB step ran before the event collector and HPA steps, so a rejected PDB write (admission policy, quota, RBAC) aborted the reconcile and left the aggregator without autoscaling until the write recovered. Now it runs last; the failure is still reported and retried. Verified on a live cluster with an admission policy denying PDB writes: the HPA is created while the PDB retries.
Along the way: field docs now state that
minAvailablewins when bothminAvailableandmaxUnavailableare set (CRDs regenerated, helm mirrored), and unit tests for the PDB and HPA reconcile gates plus a regression test for the new ordering. To make the gates testable,Controller.ClientSetandconfigcheck.Newtakekubernetes.Interfacenow; callers are unchanged.