-
Notifications
You must be signed in to change notification settings - Fork 39
Rename example-backend to backend & fix ci #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -143,14 +143,17 @@ func (h *handler) handleServiceExport(w http.ResponseWriter, r *http.Request) { | |||||||||||||||||||||||||||||||||
| logger.Error(err, "failed to parse version %q", componentbaseversion.Get().GitVersion) | ||||||||||||||||||||||||||||||||||
| ver = "v0.0.0" | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| prettyName := h.providerPrettyName | ||||||||||||||||||||||||||||||||||
| if prettyName == "" { | ||||||||||||||||||||||||||||||||||
| prettyName = "backend" | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
| provider := &kubebindv1alpha2.BindingProvider{ | ||||||||||||||||||||||||||||||||||
| TypeMeta: metav1.TypeMeta{ | ||||||||||||||||||||||||||||||||||
| APIVersion: kubebindv1alpha2.GroupVersion, | ||||||||||||||||||||||||||||||||||
| Kind: "BindingProvider", | ||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||
| Version: ver, | ||||||||||||||||||||||||||||||||||
| ProviderPrettyName: "example-backend", | ||||||||||||||||||||||||||||||||||
| ProviderPrettyName: prettyName, | ||||||||||||||||||||||||||||||||||
| AuthenticationMethods: []kubebindv1alpha2.AuthenticationMethod{ | ||||||||||||||||||||||||||||||||||
|
Comment on lines
155
to
157
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do not hard-code ProviderPrettyName; honor the configured flag. This ignores NewHandler’s providerPrettyName (and the CLI flag like --pretty-name), reducing configurability. Apply this to use the configured value with a sane default: @@
- provider := &kubebindv1alpha2.BindingProvider{
+ // prefer configured pretty name; default to "backend"
+ prettyName := h.providerPrettyName
+ if prettyName == "" {
+ prettyName = "backend"
+ }
+ provider := &kubebindv1alpha2.BindingProvider{
@@
- ProviderPrettyName: "backend",
+ ProviderPrettyName: prettyName,📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||
| Method: "OAuth2CodeGrant", | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.