Bump deps & fix provider startup#335
Conversation
WalkthroughRemoved provider startup from Server.Run in backend/server.go and deleted an unused os import. Upgraded Go module dependencies across root, CLI, and generator go.mod files (k8s.io/* and golang.org/x/* bumps and replace/require adjustments). Updated contrib/kcp README example paths and the release publishing doc tag from v0.5.0-rc2 to v0.5.1. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant Server
participant Provider
rect rgb(235,245,255)
note over Server,Provider: Previous flow (before this change)
User->>Server: Run()
Server->>Provider: Start() (spawn goroutine)
Provider-->>Server: Error / OK (async)
Server-->>User: Listen or exit on provider error
end
rect rgb(240,255,240)
note over Server: New flow (after this change)
User->>Server: Run()
Server-->>User: Listen (provider startup removed)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1d2503f to
8a7e516
Compare
8a7e516 to
bbbf7c5
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
cli/go.sumis excluded by!**/*.sumdocs/generators/cli-doc/go.sumis excluded by!**/*.sumgo.sumis excluded by!**/*.sum
📒 Files selected for processing (6)
backend/server.go(0 hunks)cli/go.mod(3 hunks)contrib/kcp/README.md(3 hunks)docs/content/contributing/guides/publishing-a-new-kube-bind-release.md(1 hunks)docs/generators/cli-doc/go.mod(2 hunks)go.mod(4 hunks)
💤 Files with no reviewable changes (1)
- backend/server.go
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/content/contributing/guides/publishing-a-new-kube-bind-release.md
36-36: Inconsistent indentation for list items at the same level
Expected: 0; Actual: 1
(MD005, list-indent)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Generate and push docs
- GitHub Check: verify
- GitHub Check: lint
- GitHub Check: go-test-e2e
- GitHub Check: go-test
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt> On-behalf-of: @SAP mangirdas.judeikis@sap.com
bbbf7c5 to
11afe3a
Compare
|
Mhm I think something is still off; I tried rebasing #333 onto this last night and the backend (prebuilt, haven't tested code-based) errored with |
|
Still in favour of merging this. It's cumbersome to constantly rebase and this looks good imho. |
Summary
What Type of PR Is This?
/kind cleanup
Related Issue(s)
Fixes #
Release Notes
Summary by CodeRabbit