Skip to content

Bump deps & fix provider startup#335

Merged
mjudeikis merged 1 commit into
kbind-dev:mainfrom
mjudeikis:mjudeikis/bump.deps
Oct 6, 2025
Merged

Bump deps & fix provider startup#335
mjudeikis merged 1 commit into
kbind-dev:mainfrom
mjudeikis:mjudeikis/bump.deps

Conversation

@mjudeikis

@mjudeikis mjudeikis commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Summary

What Type of PR Is This?

/kind cleanup

Related Issue(s)

Fixes #

Release Notes

Removes fork usage for multicluster-runtime 
Fixes provider startup

Summary by CodeRabbit

  • Refactor
    • Server startup adjusted: provider no longer auto-starts during boot.
  • Documentation
    • Updated contrib/kcp README examples, paths, cluster and secret references.
    • Publishing guide examples updated to v0.5.1.
  • Chores
    • Upgraded Kubernetes- and golang.org/x- dependencies across modules to newer patch/minor versions.
    • Simplified module configuration by removing legacy replacements and aligning dependency versions.

@mjudeikis
mjudeikis requested a review from a team as a code owner October 2, 2025 13:49
@coderabbitai

coderabbitai Bot commented Oct 2, 2025

Copy link
Copy Markdown

Walkthrough

Removed provider startup from Server.Run in backend/server.go and deleted an unused os import. Upgraded Go module dependencies across root, CLI, and generator go.mod files (k8s.io/* and golang.org/x/* bumps and replace/require adjustments). Updated contrib/kcp README example paths and the release publishing doc tag from v0.5.0-rc2 to v0.5.1.

Changes

Cohort / File(s) Summary of changes
Server boot flow
backend/server.go
Removed provider startup logic (no goroutine spawn, no provider error handling/exit) and removed unused os import.
Module/dependency updates (root + CLI + generators)
go.mod, cli/go.mod, docs/generators/cli-doc/go.mod
Bumped multiple k8s.io and golang.org/x module versions, removed/rewrote many replace directives in root go.mod, updated multicluster-runtime and kcp-related module references; no runtime code changes.
Docs: KCP contrib usage
contrib/kcp/README.md
Updated example CRD/apply paths to contrib/kcp/deploy/examples/..., adjusted cluster identifier, bind file path, secret name, and final example object path.
Docs: release publishing
docs/content/contributing/guides/publishing-a-new-kube-bind-release.md
Replaced occurrences of v0.5.0-rc2 with v0.5.1 in publishing workflow documentation and command snippets.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant User
  participant Server
  participant Provider

  rect rgb(235,245,255)
  note over Server,Provider: Previous flow (before this change)
  User->>Server: Run()
  Server->>Provider: Start() (spawn goroutine)
  Provider-->>Server: Error / OK (async)
  Server-->>User: Listen or exit on provider error
  end

  rect rgb(240,255,240)
  note over Server: New flow (after this change)
  User->>Server: Run()
  Server-->>User: Listen (provider startup removed)
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • ntnn
  • s-urbaniak

Poem

I nibble modules, hop through trees,
The provider naps — no wake-up breeze.
Docs updated, paths set right,
Tags bumped neat into the night.
A carrot release, crisp and bright 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning Although the required headings are present, the Summary section lacks any description and the Related Issue(s) field contains an incomplete placeholder, so the template is not fully filled out. Provide a concise summary under “## Summary” and specify a valid issue reference or explicitly state “None” in the Related Issue(s) section to complete the template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly summarizes the two main changes in the PR: bumping dependencies and fixing provider startup, and clearly reflects the scope of the modifications.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bbbf7c5 and 11afe3a.

⛔ Files ignored due to path filters (3)
  • cli/go.sum is excluded by !**/*.sum
  • docs/generators/cli-doc/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (6)
  • backend/server.go (0 hunks)
  • cli/go.mod (3 hunks)
  • contrib/kcp/README.md (4 hunks)
  • docs/content/contributing/guides/publishing-a-new-kube-bind-release.md (1 hunks)
  • docs/generators/cli-doc/go.mod (2 hunks)
  • go.mod (4 hunks)
💤 Files with no reviewable changes (1)
  • backend/server.go
🚧 Files skipped from review as they are similar to previous changes (3)
  • docs/content/contributing/guides/publishing-a-new-kube-bind-release.md
  • cli/go.mod
  • docs/generators/cli-doc/go.mod
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: verify
  • GitHub Check: go-test
  • GitHub Check: lint
  • GitHub Check: go-test-e2e
  • GitHub Check: Generate and push docs
🔇 Additional comments (1)
contrib/kcp/README.md (1)

133-136: Paths for examples now consistent.
Thanks for updating the final apply command to match the earlier contrib/kcp/deploy/examples locations; the walkthrough no longer sends readers to the old path.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mjudeikis
mjudeikis force-pushed the mjudeikis/bump.deps branch 2 times, most recently from 1d2503f to 8a7e516 Compare October 2, 2025 13:51
Comment thread go.mod Outdated
cnvergence
cnvergence previously approved these changes Oct 2, 2025

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1db6624 and bbbf7c5.

⛔ Files ignored due to path filters (3)
  • cli/go.sum is excluded by !**/*.sum
  • docs/generators/cli-doc/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (6)
  • backend/server.go (0 hunks)
  • cli/go.mod (3 hunks)
  • contrib/kcp/README.md (3 hunks)
  • docs/content/contributing/guides/publishing-a-new-kube-bind-release.md (1 hunks)
  • docs/generators/cli-doc/go.mod (2 hunks)
  • go.mod (4 hunks)
💤 Files with no reviewable changes (1)
  • backend/server.go
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/content/contributing/guides/publishing-a-new-kube-bind-release.md

36-36: Inconsistent indentation for list items at the same level
Expected: 0; Actual: 1

(MD005, list-indent)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Generate and push docs
  • GitHub Check: verify
  • GitHub Check: lint
  • GitHub Check: go-test-e2e
  • GitHub Check: go-test

Comment thread contrib/kcp/README.md
Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt>
On-behalf-of: @SAP mangirdas.judeikis@sap.com
@mjudeikis
mjudeikis force-pushed the mjudeikis/bump.deps branch from bbbf7c5 to 11afe3a Compare October 3, 2025 06:00
@ntnn

ntnn commented Oct 4, 2025

Copy link
Copy Markdown
Member

Mhm I think something is still off; I tried rebasing #333 onto this last night and the backend (prebuilt, haven't tested code-based) errored with cluster not found.
Maybe that's due to kcp-dev/multicluster-provider not being updated and something conflicting between the mcr dependency here and in the kcp provider?

@ntnn

ntnn commented Oct 5, 2025

Copy link
Copy Markdown
Member

Still in favour of merging this. It's cumbersome to constantly rebase and this looks good imho.

@mjudeikis
mjudeikis merged commit 3abf1be into kbind-dev:main Oct 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants