Skip to content

remove unused hack/lib.sh#356

Merged
ntnn merged 1 commit into
kbind-dev:mainfrom
xrstf:clean-lib
Nov 4, 2025
Merged

remove unused hack/lib.sh#356
ntnn merged 1 commit into
kbind-dev:mainfrom
xrstf:clean-lib

Conversation

@xrstf

@xrstf xrstf commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Summary

This file was added a long time ago to support running the CRD generator in a container, to make it immune against GOPATH shenanigans.

The CRD generation has since then long been renewed and doesn't rely on such hacks anymore, but the lib.sh was never removed. It is entirely unused though.

What Type of PR Is This?

/kind cleanup

Release Notes

NONE

Summary by CodeRabbit

  • Chores
    • Removed internal build utility library. This maintenance change consolidates build infrastructure and eliminates deprecated helper functions. Systems relying on these internal utilities will require updates to use alternative approaches or direct implementations.

On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
xrstf requested a review from a team as a code owner November 3, 2025 16:20
@coderabbitai

coderabbitai Bot commented Nov 3, 2025

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The hack/lib.sh file, a comprehensive Bash utility library spanning CI/CD workflows, Kubernetes operations, Docker management, dashboard operations, and logging utilities, has been completely removed from the codebase.

Changes

Cohort / File(s) Change Summary
Library Removal
hack/lib.sh
Deleted entire Bash utility library containing 27 functions including worker name normalization, retry logic with JUnit integration, containerization helpers, SSH/Vault authentication, dashboard operations, trap management, Kubernetes/Docker orchestration, and logging utilities.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

  • Verification that no remaining scripts or workflows depend on the removed utility functions
  • Confirmation that CI/CD pipelines continue to operate without these utilities
  • Validation that container orchestration, Docker initialization, and deployment readiness checks are properly handled elsewhere or no longer required
  • Assessment of impact on dashboard management and tag verification workflows
  • Confirmation that retry logic, logging, and metric collection have been replaced or are no longer necessary

Poem

A library of helpers, once vital and vast,
Makes way for the future, releasing the past.
Simplified pathways, dependencies cleared,
The toolkit evolves as the new code appeared.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removal of the unused hack/lib.sh file. It is concise, clear, and directly reflects the changeset.
Description check ✅ Passed The description includes all required sections from the template: Summary (explaining historical context and current status), PR type (/kind cleanup), and Release Notes (NONE). Content is complete and relevant.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f026310 and 47e1342.

📒 Files selected for processing (1)
  • hack/lib.sh (0 hunks)
💤 Files with no reviewable changes (1)
  • hack/lib.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xrstf

xrstf commented Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 3, 2025

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ntnn
ntnn merged commit 8108a52 into kbind-dev:main Nov 4, 2025
6 checks passed
@xrstf
xrstf deleted the clean-lib branch November 4, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants