Skip to content

clean up the omitempty tags and typo in sdk v1alpha2 #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnvergence merged 1 commit into from
Dec 2, 2025
Merged

clean up the omitempty tags and typo in sdk v1alpha2 #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/apis/kubebind/v1alpha2/apiservicebinding_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,14 @@ const (
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=`.metadata.creationTimestamp`,priority=0
type APIServiceBinding struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
metav1.ObjectMeta `json:"metadata"`

// spec specifies how an API service from a service provider should be bound in the
// local consumer cluster.
Spec APIServiceBindingSpec `json:"spec"`

// status contains reconciliation information for a service binding.
Status APIServiceBindingStatus `json:"status,omitempty"`
Status APIServiceBindingStatus `json:"status"`
}

func (in *APIServiceBinding) GetConditions() conditionsapi.Conditions {
Expand Down
4 changes: 2 additions & 2 deletions sdk/apis/kubebind/v1alpha2/apiserviceexport_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,15 @@ const (
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=`.metadata.creationTimestamp`,priority=0
type APIServiceExport struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
metav1.ObjectMeta `json:"metadata"`

// spec specifies the resource.
// +required
// +kubebuilder:validation:Required
Spec APIServiceExportSpec `json:"spec"`

// status contains reconciliation information for the resource.
Status APIServiceExportStatus `json:"status,omitempty"`
Status APIServiceExportStatus `json:"status"`
}

func (in *APIServiceExport) GetConditions() conditionsapi.Conditions {
Expand Down
4 changes: 2 additions & 2 deletions sdk/apis/kubebind/v1alpha2/apiserviceexportrequest_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const (
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=`.metadata.creationTimestamp`,priority=0
type APIServiceExportRequest struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
metav1.ObjectMeta `json:"metadata"`

// spec specifies how an API service from a service provider should be bound in the
// local consumer cluster.
Expand Down Expand Up @@ -234,7 +234,7 @@ type PermissionClaim struct {
// Selector is a resource selector that selects objects of a GVR.
// +required
// +kubebuilder:validation:Required
Selector Selector `json:"selector,omitempty"`
Selector Selector `json:"selector"`
}

// Owner is the owner of the resource.
Expand Down
4 changes: 2 additions & 2 deletions sdk/apis/kubebind/v1alpha2/apiserviceexporttemplate_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ import (
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=`.metadata.creationTimestamp`,priority=0
type APIServiceExportTemplate struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
metav1.ObjectMeta `json:"metadata"`

// spec specifies the template.
// +required
// +kubebuilder:validation:Required
Spec APIServiceExportTemplateSpec `json:"spec"`

// status contains reconciliation information for the template.
Status APIServiceExportTemplateStatus `json:"status,omitempty"`
Status APIServiceExportTemplateStatus `json:"status"`
}

func (in *APIServiceExportTemplate) GetConditions() conditionsapi.Conditions {
Expand Down
4 changes: 2 additions & 2 deletions sdk/apis/kubebind/v1alpha2/apiservicenamespace_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@ const (
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=`.metadata.creationTimestamp`,priority=0
type APIServiceNamespace struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
metav1.ObjectMeta `json:"metadata"`

// spec specifies a service namespace.
Spec APIServiceNamespaceSpec `json:"spec"`

// status contains reconciliation information for a service namespace
Status APIServiceNamespaceStatus `json:"status,omitempty"`
Status APIServiceNamespaceStatus `json:"status"`
}

type APIServiceNamespaceSpec struct {
Expand Down
4 changes: 2 additions & 2 deletions sdk/apis/kubebind/v1alpha2/bindingresponse_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ type BindingResponseAuthenticationOAuth2CodeGrant struct {
// authentication and resource selection on the service provider website.
type BindableResourcesRequest struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
metav1.ObjectMeta `json:"metadata"`

TemplateRef APIServiceExportTemplateRef `json:"templateRef,omitempty"`
TemplateRef APIServiceExportTemplateRef `json:"templateRef"`
}

type APIServiceExportTemplateRef struct {
Expand Down
4 changes: 2 additions & 2 deletions ...pis/kubebind/v1alpha2/boundchema_types.go → ...is/kubebind/v1alpha2/boundschema_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ type ExportedSchemas map[string]*BoundSchema
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp"
type BoundSchema struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
metav1.ObjectMeta `json:"metadata"`

Spec BoundSchemaSpec `json:"spec"`
Status BoundSchemaStatus `json:"status,omitempty"`
Status BoundSchemaStatus `json:"status"`
}

// ResourceGroupName returns the group name of the resource.
Expand Down
4 changes: 2 additions & 2 deletions sdk/apis/kubebind/v1alpha2/clusterbinding_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ const (
// +kubebuilder:validation:XValidation:rule="self.metadata.name == \"cluster\"",message="cluster binding name should be cluster"
type ClusterBinding struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
metav1.ObjectMeta `json:"metadata"`

// spec represents the data in the newly created ClusterBinding.
// +required
// +kubebuilder:validation:Required
Spec ClusterBindingSpec `json:"spec"`

// status contains reconciliation information for the service binding.
Status ClusterBindingStatus `json:"status,omitempty"`
Status ClusterBindingStatus `json:"status"`
}

func (in *ClusterBinding) GetConditions() conditionsapi.Conditions {
Expand Down
4 changes: 2 additions & 2 deletions sdk/apis/kubebind/v1alpha2/collection_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,15 @@ import (
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=`.metadata.creationTimestamp`,priority=0
type Collection struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
metav1.ObjectMeta `json:"metadata"`

// spec specifies the collection.
// +required
// +kubebuilder:validation:Required
Spec CollectionSpec `json:"spec"`

// status contains reconciliation information for the collection.
Status CollectionStatus `json:"status,omitempty"`
Status CollectionStatus `json:"status"`
}

func (in *Collection) GetConditions() conditionsapi.Conditions {
Expand Down