replace go-install with µget, cleanup Makefile#418
Merged
Conversation
On-behalf-of: @SAP christoph.mewes@sap.com
Contributor
|
@coderabbitai review this please |
|
@mjudeikis I will review the changes in this PR. ✅ Actions performedReview triggered.
|
cnvergence
approved these changes
Dec 10, 2025
cnvergence
left a comment
Member
There was a problem hiding this comment.
I see it is running in kcp for some time already, happy to try it out in the kube-bind
mjudeikis
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follows our changes in kcp and its related sibling projects. µget is superior to go-install because
Like in the other projects, the shell scripts themselves are kept/meant to be usable without make, so they install (using make, however) their dependencies as they see fit.
I also unfuddled with TOOLS_GO_BIN_DIR thingymabob, which seems to have been mostly broken and unusable. From now on, all binaries we produce end up in
bin/, all tools we use from external sources are inhack/tools. It made no senses to me to place applyconfiguration-gen in the same folder as the backend binary.I also took the liberty to move some of the larger chunks of shell code and moved them into actual script files. My brain is bad at reading and writing 20+ line inline bash scripts in Makefiles.
What Type of PR Is This?
/kind cleanup
Release Notes