Skip to content

replace go-install with µget, cleanup Makefile#418

Merged
xrstf merged 1 commit into
kbind-dev:mainfrom
xrstf:ugetv2
Dec 11, 2025
Merged

replace go-install with µget, cleanup Makefile#418
xrstf merged 1 commit into
kbind-dev:mainfrom
xrstf:ugetv2

Conversation

@xrstf

@xrstf xrstf commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Summary

This follows our changes in kcp and its related sibling projects. µget is superior to go-install because

  • it can handle Go 1.25 compatibility hacks
  • can and is optimized for installing non-Go binaries
  • it does checksumming
  • it can print the resulting binary path
  • it can use a system-wide cache, great for when many projects use µget and all of them want golangci-lint
  • it doesn't suffer from the NIH syndrome

Like in the other projects, the shell scripts themselves are kept/meant to be usable without make, so they install (using make, however) their dependencies as they see fit.

I also unfuddled with TOOLS_GO_BIN_DIR thingymabob, which seems to have been mostly broken and unusable. From now on, all binaries we produce end up in bin/, all tools we use from external sources are in hack/tools. It made no senses to me to place applyconfiguration-gen in the same folder as the backend binary.

I also took the liberty to move some of the larger chunks of shell code and moved them into actual script files. My brain is bad at reading and writing 20+ line inline bash scripts in Makefiles.

What Type of PR Is This?

/kind cleanup

Release Notes

NONE

On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
xrstf marked this pull request as ready for review December 5, 2025 12:12
@xrstf
xrstf requested a review from a team as a code owner December 5, 2025 12:12
@mjudeikis

Copy link
Copy Markdown
Contributor

@coderabbitai review this please

@coderabbitai

coderabbitai Bot commented Dec 10, 2025

Copy link
Copy Markdown

@mjudeikis I will review the changes in this PR.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cnvergence cnvergence left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it is running in kcp for some time already, happy to try it out in the kube-bind

@xrstf
xrstf merged commit e96e779 into kbind-dev:main Dec 11, 2025
11 of 12 checks passed
@xrstf
xrstf deleted the ugetv2 branch December 11, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants