move client-side-redirect into web app part of kube-bind backend#436
Merged
Conversation
cnvergence
force-pushed
the
fix-client-side-redirect
branch
from
January 9, 2026 13:34
d835a54 to
fcd1fb6
Compare
cnvergence
changed the title
cnvergence
marked this pull request as ready for review
January 20, 2026 14:56
xrstf
reviewed
Jan 20, 2026
Contributor
|
Just to be sure: "Moving from the backend" still means it's technically part of what kube-bind considers the backend, right? I thought you moved it into the kubectl plugin, but it's still in the backend, just the frontend part of the backend (oh us, naming is hard... :D)? I guess "client-side" would be just as confusing a term :D |
mjudeikis
reviewed
Jan 21, 2026
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
cnvergence
force-pushed
the
fix-client-side-redirect
branch
from
January 21, 2026 11:14
fcd1fb6 to
dfcecb3
Compare
mjudeikis
reviewed
Jan 21, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
cnvergence
changed the title
mjudeikis
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move redirect URL construction from backend to frontend.
Backend now stores redirect and session data and web app builds callback URL client-side.
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #362
Release Notes