web: fix bind request format

[gman0]

Summary

I've started getting an error I haven't seen before:

Snippet from backend logs:

E0203 13:07:24.825942  304155 handler.go:365] "invalid bind request" err="missing cluster identity" method="POST" url="/api/bind?cluster_id=qa4l1c3g0gcx1r02&consumer_id=d36d467f-7e9d-4f1b-8d9e-e0612160c37f"
I0203 13:10:51.839099  304155 manager.go:299] "User is allowed to bind" subject="kube-bind-embedded-user" cluster="qa4l1c3g0gcx1r02" method="POST" path="/api/bind" groups=["engineering","devops"] user="kube-bind-embedded-user"
E0203 13:10:51.839157  304155 handler.go:365] "invalid bind request" err="missing cluster identity" method="POST" url="/api/bind?cluster_id=qa4l1c3g0gcx1r02&consumer_id=d36d467f-7e9d-4f1b-8d9e-e0612160c37f"

After closer inspection, the request payload DOES contain the cluster identity:

https://github.com/kube-bind/kube-bind/blob/ce81e736053180fe0a9e1d4b92d62c095703f504/backend/http/handler.go#L348-L352

{
  "metadata": {
    "name": "cowboys"
  },
  "templateRef": {
    "name": "cowboys"
  },
  "clusterIdentity": {
    "identity": "d36d467f-7e9d-4f1b-8d9e-e0612160c37f"
  }
}

Which, after being unmarshalled into BindableResourcesRequest, results in:

v1alpha2.BindableResourcesRequest{
  TypeMeta:v1.TypeMeta{
    Kind:"",
    APIVersion:""
  },
  ObjectMeta:v1.ObjectMeta{
    Name:"cowboys",
    GenerateName:"",
    Namespace:"",
    SelfLink:"",
    UID:"",
    ResourceVersion:"",
    Generation:0,
    CreationTimestamp:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC),
    DeletionTimestamp:<nil>,
    DeletionGracePeriodSeconds:(*int64)(nil),
    Labels:map[string]string(nil),
    Annotations:map[string]string(nil),
    OwnerReferences:[]v1.OwnerReference(nil),
    Finalizers:[]string(nil),
    ManagedFields:[]v1.ManagedFieldsEntry(nil)
  },
  Spec:v1alpha2.BindableResourcesRequestSpec{
    TemplateRef:v1alpha2.APIServiceExportTemplateRef{
      Name:""
    },
    ClusterIdentity:v1alpha2.ClusterIdentity{
      Identity:""
    },
    Author:"",
    KubeconfigSecretRef:(*v1alpha2.LocalSecretKeyRef)(nil),
    TTLAfterFinished:(*v1.Duration)(nil)
  },
  Status:v1alpha2.BindableResourcesRequestStatus{
    Phase:"",
    KubeconfigSecretRef:(*v1alpha2.LocalSecretKeyRef)(nil),
    CompletionTime:<nil>,
    Conditions:[]v1.Condition(nil)
  }
}

Clearly, the payload is missing spec dictionary. This PR adds it, and the BindableResourcesRequest struct is now populated correctly.

What Type of PR Is This?

/kind bug

???

Related Issue(s)

Fixes #

Release Notes

NONE

[mjudeikis]

web/src/types/binding.ts needs updating

[mjudeikis]

and author was made required:

// Author is the identifier of the entity that created this binding request.
	// This is used for audit purposes and to track who initiated the binding.
	//
	// +required
	// +kubebuilder:validation:Required
	Author string `json:"author"`

either add placeholder from UI or make it optional