feat: implement multi-provider binding support for CRDs (#173)#594
Open
alokkumardalei-wq wants to merge 1 commit into
Open
feat: implement multi-provider binding support for CRDs (#173)#594alokkumardalei-wq wants to merge 1 commit into
alokkumardalei-wq wants to merge 1 commit into
Conversation
Signed-off-by: alokkumardalei-wq <alokkumardalei2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses Issue #173 by adding support for multi-provider bindings in
kube-bind. It enables a single consumer cluster to bind and manage Custom Resources from multiple provider clusters without conflict.Changes made:
API Extensions:
sdk/apis/kubebind/v1alpha2/bindingresponse_types.go).ProviderID (string)and IsDefault(bool) inAPIServiceBindingSpec(sdk/apis/kubebind/v1alpha2/apiservicebinding_types.go).Backend:
manager.goto retrieve the provider cluster's kube-system namespace UID and set it as ProviderID.BindingResourceResponsepayload handled by the HTTP server (handler.go).BindingResourceResponsesecret generated by the UI binding flow inbindableresourcesrequest_controller.go.CLI Binding Flow:
Konnector Core Engine:
servicebindingbundle_reconcile.goto inject the targetkube-systemUID into the generatedAPIServiceBindingspec upon reconciling provider connections.spec_controller.goandstatus_controller.go) inpkg/konnector/controllers/cluster/serviceexport/to filter inbound syncing events. Controllers now only route resources that contain theprovider.kube-bind.io/provider-idannotation matching their assigned ProviderID, or any resource if they hold the IsDefault flag.Testing and Validation
make build) that all integration logic compiles cleanly across both CLI and Backend components.Fixes #173