fix(v1): stop escaping / in ensure_v1#155
Open
jakobhellermann wants to merge 1 commit into
Open
Conversation
jakobhellermann
commented
Apr 30, 2026
| } | ||
| filepicker location="zellij:strider" { | ||
| cwd "\/" | ||
| cwd "/" |
Author
There was a problem hiding this comment.
The test asserts
v1_to_v2(v1) == v2
v2_to_v1(v2) == v1
This is incompatible with both
/(v1) ->/(v2)\/(v1) ->/(v2)
So I changed this to be a /. The new tests assert that v1->v2 unescapes the forward slash.
`KdlEntry::ensure_v1` was replacing every `/` in non-raw v1 string literals with `\/`. While that's allowed in v1 (not in v2), it is not necessary. `ensure_v2` strips `\/`, as expected.
jakobhellermann
force-pushed
the
fix-escape-slash-v1
branch
from
96208e0 to
cd3cd62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KdlEntry::ensure_v1was replacing every/in non-raw v1 string literals with\/. While that's allowed in v1 (not in v2), it is not necessary.ensure_v2strips\/, as expected.