Repository navigation
fix(bin): stop claiming check coverage on merged contributions - #4
Merged
Merged
Conversation
…eouts as budget exhaustion Treat individual forge call timeouts as budget exhaustion under the default 20s budget, avoiding misclassifying bounded call expiration as forge failures. For merged pull requests, skip redundant check-runs, statuses, repo, and pr view calls while continuing to capture post-merge maintainer comments and reviews. Preserve stable terminal states (merged, closed) and stay silent when subsequent re-checks fail, preventing check intervals from triggering false wakes.
…n; only merged is terminal
…ord, fix test ordering
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Supervision must not be repeatedly interrupted by contribution checks that cannot complete for already-merged Firstmate pull requests.
In
bin/fm-contributions.sh poll, merged pull requests repeatedly failed forge reads and were marked with"error": "forge observation unavailable or changed during read", causingbin/fm-watch.shto wake and exit every 300 seconds. This change ensures merged pull requests are observed efficiently for post-merge maintainer comments without spurious errors, repeated unavailable-observation wakes, or false operational gaps.What Changed
bin/fm-contributions.sh): Separated individual forge call timeouts (5-second bound) from overall poll budget exhaustion (20-second bound). A single URL timing out is treated as an isolated failure and rotates to the back of the queue without exhausting the remaining budget.bin/fm-contributions.sh): For a verified merged PR, redundant check-runs, statuses, repo push permissions, andpr viewcalls are skipped during observation. Comments and reviews continue to be queried to capture post-merge maintainer feedback.bin/fm-contributions.sh): A merged PR re-check failure preserves the prior merged observation, advanceschecked_at, and records the error for queue rotation while suppressing repetitiveobservation unavailablestdout lines.bin/fm-contributions.jq): Gateddistinct_checks,missing_verdicts,pending_checks, andfailed_checksvia$currentso merged rows report 0 current lanes and 0 operational gaps in Bearings andsnapshot --all, while pre-merge check history is preserved verbatim in the record file. Closed-unmerged behavior is unchanged.bin/fm-contributions.sh): Updated header contract to accurately document observed vs historical fields and that merged work claims no active check coverage.Verification
tests/fm-contributions.test.shcovering per-call timeouts, merged re-check error recording and silence, post-merge comment wakes, URL queue rotation, absent-lane retirement, and zero current lane reporting on merged rows. All 40 test cases pass cleanly.bin/fm-lint.sh(ShellCheck and actionlint clean).no-mistakesthrough 6 review fix rounds, 8 live validation scenarios against real GitHub endpoints, document review, and lint.