[kelos-bot]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Prevents the kelos bot from recursively triggering self-development TaskSpawners.

Several self-development TaskSpawners listed kelos-bot[bot] as a positive author allowlist entry alongside gjkim42. Combined with bodyContains: /kelos <command> filters, this allowed agent-authored comments that mention /kelos api-review, /kelos review, /kelos pick-up, or /kelos plan (e.g. recommendations in planner/reviewer outputs) to trigger another spawner — the recursion vector described in the issue.

The GitHubWebhook.ExcludeAuthors field already exists in the API and is evaluated before filters, taking precedence over filter-level Author matches. This PR applies it at the top level of the affected spawners and drops the now-redundant author: kelos-bot[bot] filter entries:

• kelos-workers
• kelos-planner
• kelos-pr-responder
• kelos-reviewer
• kelos-api-reviewer

kelos-triage is intentionally left unchanged — it triages bot-created issues opened by kelos-self-update, which is the desired workflow. kelos-squash-commits already restricts to gjkim42 only.

Which issue(s) this PR is related to:

Fixes #1098

Special notes for your reviewer:

This is in tension with #979's finding that kelos-squash-commits is the only command handler missing kelos-bot[bot] from its author allowlist. Issue #1098 takes the opposite direction (no bot-on-bot triggers via these command filters), so #979's symmetry argument no longer applies for these filter blocks.

make verify and make test pass locally.

Does this PR introduce a user-facing change?

NONE

[cubic-dev-ai]

No issues found across 5 files

[greptile-apps]

Greptile Summary

This PR closes the bot-on-bot recursion vector (issue #1098) by adding excludeAuthors: kelos-bot[bot] at the top-level githubWebhook spec of five TaskSpawners (kelos-workers, kelos-planner, kelos-pr-responder, kelos-reviewer, kelos-api-reviewer) and removing the now-redundant per-filter author: kelos-bot[bot] entries. The approach is correct — excludeAuthors is evaluated before filter-level author matches — and the intentional carve-outs (kelos-triage, kelos-squash-commits) are left unchanged as documented.

• The PR uses /kind bug, but CLAUDE.md specifies that PRs modifying only self-development/ files should use /kind cleanup.

Confidence Score: 4/5

Safe to merge — the recursion fix is correct and complete; only a minor /kind label convention violation remains.

All changed files are simple YAML config edits that are logically correct. The only finding is a P2 style violation (/kind bug instead of /kind cleanup per CLAUDE.md), which does not affect runtime behavior.

No files require special attention.

Important Files Changed

Filename	Overview
self-development/kelos-api-reviewer.yaml	Adds top-level excludeAuthors: kelos-bot[bot] and removes both redundant author: kelos-bot[bot] entries (issue_comment and pull_request_review) from the api-review command filters.
self-development/kelos-reviewer.yaml	Adds top-level excludeAuthors: kelos-bot[bot] and removes both redundant author: kelos-bot[bot] entries (issue_comment and pull_request_review) from the review command filters.
self-development/kelos-pr-responder.yaml	Adds top-level excludeAuthors: kelos-bot[bot] and removes the redundant issue_comment pick-up filter scoped to kelos-bot[bot]; the pull_request_review filter (which already had no author restriction) is now correctly guarded by the top-level exclusion.
self-development/kelos-planner.yaml	Adds top-level excludeAuthors: kelos-bot[bot] and removes the redundant per-filter author: kelos-bot[bot] entry from the plan command filter.
self-development/kelos-workers.yaml	Adds top-level excludeAuthors: kelos-bot[bot] and removes the now-redundant per-filter author: kelos-bot[bot] entry for the issue_comment pick-up filter.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    GH[GitHub Webhook Event] --> EA{excludeAuthors check}
    EA -- "author == kelos-bot[bot]" --> DROP[🚫 Event dropped — no spawner triggered]
    EA -- "author != kelos-bot[bot]" --> FL{Filter evaluation}
    FL -- "filter matches e.g. gjkim42 + bodyContains" --> SPAWN[✅ TaskSpawner fires]
    FL -- no match --> NOOP[Event ignored]

    subgraph Before this PR
        OLD_FL{Filter evaluation OLD} -- "author: gjkim42 match" --> OLD_SPAWN1[TaskSpawner fires]
        OLD_FL -- "author: kelos-bot[bot] match + bodyContains /kelos cmd" --> OLD_RECURSE[⚠️ Recursive spawn!]
    end

Loading

Comments Outside Diff (1)

1. self-development/kelos-workers.yaml, line 1 (link)

   Wrong /kind label for self-development/-only PR

   CLAUDE.md (and AGENTS.md) states: "PRs that only modify files under self-development/ are internal agent improvements — use /kind cleanup and write NONE in the release-note block." All five changed files are under self-development/, so this PR should use /kind cleanup rather than /kind bug.

   Context Used: CLAUDE.md (source)

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: self-development/kelos-workers.yaml
   Line: 1
   
   Comment:
   **Wrong `/kind` label for `self-development/`-only PR**
   
   CLAUDE.md (and AGENTS.md) states: "PRs that only modify files under `self-development/` are internal agent improvements — use `/kind cleanup` and write `NONE` in the `release-note` block." All five changed files are under `self-development/`, so this PR should use `/kind cleanup` rather than `/kind bug`.
   
   **Context Used:** CLAUDE.md ([source](https://app.greptile.com/review/custom-context?memory=c0a0674a-9e65-4e96-88fa-4a29086750fb))
   
   How can I resolve this? If you propose a fix, please make it concise.

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
self-development/kelos-workers.yaml:1
**Wrong `/kind` label for `self-development/`-only PR**

CLAUDE.md (and AGENTS.md) states: "PRs that only modify files under `self-development/` are internal agent improvements — use `/kind cleanup` and write `NONE` in the `release-note` block." All five changed files are under `self-development/`, so this PR should use `/kind cleanup` rather than `/kind bug`.

_{Reviews (1): Last reviewed commit: "self-development: prevent kelos-bot from..." | Re-trigger Greptile}