Repository navigation
Track sticky issue validity verdicts - #1611
Conversation
|
/kelos review |
|
🤖 Kelos Task Status Task |
|
🤖 Kelos Reviewer Agent @gjkim42 Review SummaryVerdict: APPROVE Findings Overview
FindingsCorrectness
|
There was a problem hiding this comment.
1 issue found across 13 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="self-development/kanon/README.md">
<violation number="1" location="self-development/kanon/README.md:26">
P3: The new intro paragraph documents that discovery spawners now revalidate their unassigned slot each run and may retain, replace, or close it, but the dedicated sections for kanon-fake-user, kanon-fake-strategist, and kanon-self-update in this same README still say only "Creates or updates the single unassigned ... issue slot ... If that issue is assigned, the run treats it as ongoing and exits without editing it or creating another issue." Reading the file, a reader following the per-spawner sections won't learn about validity re-checking or closing invalid slots, which is now core behavior (it is implemented in the matching spawner YAMLs). Update those three sections to mention the keep/replace/close-on-invalid rules so the file is internally consistent.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| open `generated-by-kelos` issue slot per TaskSpawner. Its title starts with the | ||
| TaskSpawner name in brackets, and its body includes both a | ||
| `kelos-taskspawner=<name>` marker and one replaceable `Latest verdict` section. | ||
| Each run checks whether an unassigned slot is still valid against the current |
There was a problem hiding this comment.
P3: The new intro paragraph documents that discovery spawners now revalidate their unassigned slot each run and may retain, replace, or close it, but the dedicated sections for kanon-fake-user, kanon-fake-strategist, and kanon-self-update in this same README still say only "Creates or updates the single unassigned ... issue slot ... If that issue is assigned, the run treats it as ongoing and exits without editing it or creating another issue." Reading the file, a reader following the per-spawner sections won't learn about validity re-checking or closing invalid slots, which is now core behavior (it is implemented in the matching spawner YAMLs). Update those three sections to mention the keep/replace/close-on-invalid rules so the file is internally consistent.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At self-development/kanon/README.md, line 26:
<comment>The new intro paragraph documents that discovery spawners now revalidate their unassigned slot each run and may retain, replace, or close it, but the dedicated sections for kanon-fake-user, kanon-fake-strategist, and kanon-self-update in this same README still say only "Creates or updates the single unassigned ... issue slot ... If that issue is assigned, the run treats it as ongoing and exits without editing it or creating another issue." Reading the file, a reader following the per-spawner sections won't learn about validity re-checking or closing invalid slots, which is now core behavior (it is implemented in the matching spawner YAMLs). Update those three sections to mention the keep/replace/close-on-invalid rules so the file is internally consistent.</comment>
<file context>
@@ -20,13 +20,14 @@ instructions where needed: triage and squash-commits share `agentconfig.yaml`
+open `generated-by-kelos` issue slot per TaskSpawner. Its title starts with the
+TaskSpawner name in brackets, and its body includes both a
+`kelos-taskspawner=<name>` marker and one replaceable `Latest verdict` section.
+Each run checks whether an unassigned slot is still valid against the current
+repository before retaining, replacing, or closing it. Assigned issues and PRs
+are treated as ongoing human or agent work and are not updated by autonomous
</file context>
7e8de62 to
84708dc
Compare
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates the autonomous discovery issue-slot prompts for Kelos, Agora, and Kanon so every managed issue:
Latest verdictsection with status, timestamp, and evidence; andVerdict-only refreshes and invalid-slot closure preserve existing labels. The
prompts add
triage-acceptedonly when replacing the tracked candidate orcreating a new slot, so scheduled refreshes cannot undo a maintainer's triage
decision.
The manual fake-strategist Task and the self-development READMEs now follow the same contract.
Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Validation:
make verifyDoes this PR introduce a user-facing change?