Repository navigation
Paginate Session web chat history - #1621
Merged
Merged
Conversation
gjkim42
marked this pull request as ready for review
August 8, 2026 15:30
Collaborator
Author
|
/kelos review |
Contributor
|
🤖 Kelos Task Status Task |
Contributor
|
🤖 Kelos Reviewer Agent @gjkim42 Review SummaryVerdict: APPROVE (sticky comment only) Findings Overview
FindingsCorrectness
Tests
Suggestions
Key takeaways
|
gjkim42
force-pushed
the
agent/paginate-session-server-history
branch
from
August 8, 2026 15:54
e542069 to
f670217
Compare
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The Session web client previously requested history bounds without a bounded history page. Connecting to a long-running Session could therefore replay the entire event history and construct the full conversation DOM before the client became usable.
This PR makes the web client request the latest 20 history items within a 128 KiB budget, caches each Session's history cursor, and adds a Load earlier messages control that prepends older pages while preserving the reader's scroll position. The runtime history snapshot carries the latest bounded file diff independently of transcript pages, so the Changes tab remains complete without loading older messages. The client also applies paged active-turn state and the event high-water mark so queued inputs, interruptions, reconnects, and Session switching remain consistent while older pages load.
The web-facing Session server remains a transparent protocol bridge; pagination and state restoration use the shared runtime history protocol.
Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Verification:
make testmake verifygit diff --checkDoes this PR introduce a user-facing change?