Repository navigation
Display and manage pending Session messages - #1648
Merged
Merged
Conversation
gjkim42
marked this pull request as ready for review
August 12, 2026 15:27
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Collaborator
Author
|
/kelos claude-review |
Contributor
|
🤖 Kelos Task Status Task |
Contributor
|
🤖 Kelos Claude Reviewer Agent @gjkim42 Review SummaryVerdict: APPROVE Findings Overview
FindingsTests
Suggestions (optional)
Key takeaways
|
gjkim42
force-pushed
the
agent/render-pending-message-multiline
branch
from
August 12, 2026 20:54
39a2800 to
1ed8bc2
Compare
gjkim42
force-pushed
the
agent/render-pending-message-multiline
branch
from
August 12, 2026 21:25
1ed8bc2 to
b8fd195
Compare
gjkim42
enabled auto-merge
August 12, 2026 21:25
gjkim42
disabled auto-merge
August 12, 2026 21:26
Collaborator
Author
|
/kelos claude-review |
gjkim42
force-pushed
the
agent/render-pending-message-multiline
branch
from
August 12, 2026 22:23
b8fd195 to
8c42c34
Compare
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Improves the single pending Session message in three ways:
Edits and removals use the pending message revision to reject stale requests. Removal is persisted as a dedicated event, frees the pending slot immediately, prevents the buffered turn from reaching the provider, and remains removed after runtime recovery.
Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
The removal path covers both a turn still buffered in the runtime channel and the race where the dispatcher has received the turn but has not started it. Removed messages are omitted from conversation history.
Validated with
make testandmake verify.Does this PR introduce a user-facing change?