Skip to content

Remove v1alpha1 API - #1725

Open
gjkim42 wants to merge 1 commit into
mainfrom
remove-v1alpha1-api
Open

gjkim42 wants to merge 1 commit into
mainfrom
remove-v1alpha1-api

Conversation

@gjkim42

@gjkim42 gjkim42 commented Sep 3, 2026 •

Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind api

What this PR does / why we need it:

  • Removes the kelos.dev/v1alpha1 API types, generated clients, compatibility paths, conversion implementations, and version-specific tests.
  • Regenerates all 11 Kelos CRDs with v1alpha2 as their only served and storage version.
  • Keeps the version-agnostic conversion registration endpoint and CRD manifest wiring for a future API version.
  • Keeps the validating webhook configuration, admission validator, certificate wiring, and controller registration intact.
  • Adds kelos migrate-storage and makes kelos install migrate resources and status.storedVersions before removing a live CRD version.
  • Renames the manager webhook selector so it describes the shared webhook server rather than a specific conversion version.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

Before upgrading Helm-managed CRDs, run the new CLI's kelos migrate-storage command while the currently installed controller is still running. kelos install performs the same migration automatically when it detects that a live CRD version will be removed.

The storage migrator requires the target to be the live storage version, pages large resource lists, and counts only resources that were actually rewritten. These changes address the three findings from the earlier review of the pre-rebase head.

Validation:

  • make update
  • make verify
  • env -u CODEX_AUTH_JSON -u CODEX_HOME make test
  • make test-integration (console integration suites, 162 core specs, and 12 install/uninstall specs passed)
  • make build WHAT=cmd/kelos

Does this PR introduce a user-facing change?

Remove the deprecated kelos.dev/v1alpha1 API. Before upgrading Helm-managed CRDs, run `kelos migrate-storage` while the existing controller is available; `kelos install` performs this migration automatically.

@github-actions github-actions Bot added kind/api Categorizes issue or PR as related to API changes needs-triage needs-priority needs-actor release-note labels Sep 3, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 85 files

Not reviewed (too large): internal/manifests/install-crd.yaml (~28,906 lines), internal/manifests/charts/kelos/charts/kelos-crds/templates/taskspawner-crd.yaml (~8,134 lines), internal/manifests/charts/kelos/charts/kelos-crds/templates/task-crd.yaml (~7,012 lines) - if these are generated or fixture files, add them to ignored paths to exclude them from future reviews.

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread internal/cli/storage_migration.go Resolved
Comment thread internal/cli/storage_migration.go Resolved
Comment thread internal/cli/storage_migration.go Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/api Categorizes issue or PR as related to API changes needs-actor needs-priority needs-triage release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant