Repository navigation
Remove v1alpha1 API - #1725
Open
gjkim42 wants to merge 1 commit into
Open
Remove v1alpha1 API#1725gjkim42 wants to merge 1 commit into
gjkim42 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 85 files
Not reviewed (too large): internal/manifests/install-crd.yaml (~28,906 lines), internal/manifests/charts/kelos/charts/kelos-crds/templates/taskspawner-crd.yaml (~8,134 lines), internal/manifests/charts/kelos/charts/kelos-crds/templates/task-crd.yaml (~7,012 lines) - if these are generated or fixture files, add them to ignored paths to exclude them from future reviews.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
gjkim42
force-pushed
the
remove-v1alpha1-api
branch
from
October 30, 2026 11:44
b4a4cb4 to
ea4844b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api
What this PR does / why we need it:
kelos.dev/v1alpha1API types, generated clients, compatibility paths, conversion implementations, and version-specific tests.v1alpha2as their only served and storage version.kelos migrate-storageand makeskelos installmigrate resources andstatus.storedVersionsbefore removing a live CRD version.Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Before upgrading Helm-managed CRDs, run the new CLI's
kelos migrate-storagecommand while the currently installed controller is still running.kelos installperforms the same migration automatically when it detects that a live CRD version will be removed.The storage migrator requires the target to be the live storage version, pages large resource lists, and counts only resources that were actually rewritten. These changes address the three findings from the earlier review of the pre-rebase head.
Validation:
make updatemake verifyenv -u CODEX_AUTH_JSON -u CODEX_HOME make testmake test-integration(console integration suites, 162 core specs, and 12 install/uninstall specs passed)make build WHAT=cmd/kelosDoes this PR introduce a user-facing change?