Repository navigation
Fix session conversation alignment with long headers - #1747
Merged
Merged
Conversation
Collaborator
Author
|
/kelos claude-review |
Contributor
|
🤖 Kelos Task Status Task |
Contributor
|
🤖 Kelos Claude Reviewer Agent @gjkim42 Review SummaryVerdict: APPROVE Findings Overview
FindingsTests
Key takeaways
|
gjkim42
force-pushed
the
fix/console-session-alignment
branch
from
September 13, 2026 23:51
f529d48 to
296253b
Compare
gjkim42
enabled auto-merge
September 13, 2026 23:53
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Long session header metadata can expand the conversation's implicit grid column beyond the available width, shifting messages and the composer to the right and clipping header controls. Define a single
minmax(0, 1fr)column so the conversation fits its container and its content stays centered.Extend the existing viewport layout test to assert the conversation column constraint alongside the transcript and composer sizing rules.
Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
make verifypassed, including generated-file checks, frontend build, formatting, andgo vet.make test TEST_FLAGS='-run ^TestSessionUIAdaptsToPhoneViewport$'passed with the additional column assertion requested in review.Verified the layout in Chromium with long session metadata and tool output at viewport widths of 390, 800, 801, 1024, 1440, and 2048 pixels. All checks confirmed that the header and conversation content fit within the viewport and the composer and current-request bar remain centered.
Does this PR introduce a user-facing change?