Skip to content

Fix session conversation alignment with long headers - #1747

Merged
gjkim42 merged 1 commit into
mainfrom
fix/console-session-alignment
Sep 14, 2026
Merged

gjkim42 merged 1 commit into
mainfrom
fix/console-session-alignment

Conversation

@gjkim42

@gjkim42 gjkim42 commented Sep 13, 2026 •

Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

Long session header metadata can expand the conversation's implicit grid column beyond the available width, shifting messages and the composer to the right and clipping header controls. Define a single minmax(0, 1fr) column so the conversation fits its container and its content stays centered.

Extend the existing viewport layout test to assert the conversation column constraint alongside the transcript and composer sizing rules.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

make verify passed, including generated-file checks, frontend build, formatting, and go vet.

make test TEST_FLAGS='-run ^TestSessionUIAdaptsToPhoneViewport$' passed with the additional column assertion requested in review.

Verified the layout in Chromium with long session metadata and tool output at viewport widths of 390, 800, 801, 1024, 1440, and 2048 pixels. All checks confirmed that the header and conversation content fit within the viewport and the composer and current-request bar remain centered.

Does this PR introduce a user-facing change?

Fix session conversation misalignment and horizontal clipping caused by long header metadata in the web console.

@gjkim42

gjkim42 commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator Author

/kelos claude-review

@gjkim42 gjkim42 self-assigned this Sep 13, 2026
@kelos-bot

kelos-bot Bot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Kelos Task Status

Task kelos-claude-reviewer-issue-comment-02a706fb1ad9 has succeeded. ✅

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@kelos-bot

kelos-bot Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

🤖 Kelos Claude Reviewer Agent @gjkim42

Review Summary

Verdict: APPROVE
Overall correctness: patch is correct
Scope: Adds an explicit grid-template-columns: minmax(0, 1fr) to .conversation so long session header metadata can no longer widen the implicit grid column and shift the transcript, current-request bar, and composer off-center.

Findings Overview

Priority Count File:Line Summary
P0 0 — none
P1 0 — none
P2 0 — none
P3 1 internal/consoleserver/server_test.go:1615 Pin the new .conversation column rule in the existing style-assertion map

Findings

Tests

  • [P3] internal/consoleserver/server_test.go:1615 — TestSessionUIAdaptsToPhoneViewport already pins the sibling layout rules that depend on this column (desktop active request width, desktop transcript width, desktop composer width), but the new .conversation column definition that makes those rules resolve against the container width is not pinned. Because this is a fix for a defect on main, add one entry in that map (e.g. "desktop conversation column": + .conversation { min-width: 0; min-height: 0; display: grid; grid-template-columns: minmax(0, 1fr);) so a future edit that drops the explicit column trips the same test as its dependents.

Key takeaways

  • The change is correct and idiomatic for this stylesheet. With an implicit auto column, grid items keep their content-based automatic minimum, so the white-space: nowrap session metadata forces the track wider than .conversation; minmax(0, 1fr) uses a fixed 0 min sizing function, which disables that automatic minimum and lets the existing overflow: hidden / text-overflow: ellipsis on .session-meta handle clipping. The same minmax(0, 1fr) pattern is used for .app-shell, .terminal-view, and .resource-browser.
  • All .conversation children are consistent with a single column: .current-request, .messages, .changes-view, and .terminal-view set grid-column: 1, and the header and .composer-wrap auto-place into column 1. The phone media query at styles.css:600 only overrides height, so the fix applies at every breakpoint.
  • Commit message, /kind bug label, and release note follow project conventions; no docs or generated-file updates are needed.

@gjkim42
gjkim42 force-pushed the fix/console-session-alignment branch from f529d48 to 296253b Compare September 13, 2026 23:51
@gjkim42
gjkim42 enabled auto-merge September 13, 2026 23:53
@gjkim42
gjkim42 added this pull request to the merge queue Sep 14, 2026
Merged via the queue into main with commit fb95818 Sep 14, 2026
20 checks passed
@gjkim42
gjkim42 deleted the fix/console-session-alignment branch September 14, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant