Repository navigation
fix(agentsetup): drop the rerun hint from check output - #369
Merged
Merged
Conversation
A check report already shows the steps that need attention. Asking the user to run the same check afterwards gives no useful next action.
A check report and a repair hint have separate responsibilities. Keeping their checks focused makes a failure point to the behavior that changed.
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you run
app setup --agent codex --checkand a step needs attention, the report no longer ends with "Runapp setup --agent codex --checkafterwards." You get the repair steps, such asapp agent-hook install, without being told to rerun the command you just ran. A setup run without--checkstill ends with that hint.Needed by kenn-io/docbank#1491