BUG: trying to round none / string(tag) / Boolean (is_contingent)

[ajwinkworth]

BUG: Fix attempting to round none / string(tag) / Boolean (is_contingent) in backtesting.py:408

Optional float values(limit, stop, sl, tp) can be float | None. Testing for none to not pass it to round()
Boolean values (is_contingent) shouldnt be rounded.
Str values (tag) shouldn't be rounded.

See:
A fix for Comment

[kernc]

PEP 8 prescribes one empty line between methods.

[kernc]

I'd prefer this round(value, 5) if value is not None else '' be done once in the comprehension value expression (as before).

Also don't see a problem with round(is_contingent, 5) since the boolean rounds to either 1 or 0.

[ajwinkworth]

How would you prefer to deal with string tags? Take them out of the comprehension and then append them separately?

[ajwinkworth]

After some further investigation it could be:

    def __repr__(self):
        return '<Order {}>'.format(', '.join(f'{param}={round(value, 5) if isinstance(value, SupportsRound) else value}'
                                             for param, value in (
                                                 ('size', self.__size),
                                                 ('limit', self.__limit_price),
                                                 ('stop', self.__stop_price),
                                                 ('sl', self.__sl_price),
                                                 ('tp', self.__tp_price),
                                                 ('contingent', self.is_contingent),
                                                 ('tag', self.__tag),
                                             ) if value is not None))

Which I haven't tested yet. Would just need an additional import from typing for SupportsRound.

[kernc]

Something like that. Can also use isinstance(value, Number) like we do in some other places.

[jfncs]

  def __repr__(self):
      return '<Order {}>'.format(', '.join(f'{param}={round(value, 5) if isinstance(value, float) else value}'
                                           for param, value in (
                                               ('size', self.__size),
                                               ('limit', self.__limit_price),
                                               ('stop', self.__stop_price),
                                               ('sl', self.__sl_price),
                                               ('tp', self.__tp_price),
                                               ('contingent', self.is_contingent),
                                               ('tag', self.__tag),
                                           ) if value is not None))

[kernc]

Thanks and apologies. Already fixed in 8dd1e36.