Skip to content

api.main: perform authorization for GET '/user/<id>' - #431

Merged
nuclearcat merged 1 commit into
kernelci:mainfrom
JenySadadia:get-user-by-id-authorization
Dec 13, 2023
Merged

api.main: perform authorization for GET '/user/<id>'#431
nuclearcat merged 1 commit into
kernelci:mainfrom
JenySadadia:get-user-by-id-authorization

Conversation

@JenySadadia

Copy link
Copy Markdown
Contributor

Only allow authorized users to get user details matching given user ID to protect user's personal information.

Only allow authorized users to get user details
matching given user ID to protect user's personal
information.

Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
@gctucker

Copy link
Copy Markdown
Contributor

Looks like the client-side changes in kernelci-core got merged too early as they depend on this?

@nuclearcat

Copy link
Copy Markdown
Member

There was patches related to /users endpoint, they are merged, and follow-up on similar issue, this and kernelci/kernelci-core#2239 (not merged), another, /user/ endpoint.

@nuclearcat

Copy link
Copy Markdown
Member

Tested on staging with kernelci/kernelci-core#2239

@nuclearcat nuclearcat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nuclearcat
nuclearcat added this pull request to the merge queue Dec 13, 2023
Merged via the queue into kernelci:main with commit b436db4 Dec 13, 2023
@JenySadadia
JenySadadia deleted the get-user-by-id-authorization branch December 13, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants