Rework kci config with new framework - #2138
Merged
Merged
Conversation
gctucker
force-pushed
the
kci-config-rework
branch
3 times, most recently
from
October 23, 2023 19:19
dbebc77 to
c93dd85
Compare
gctucker
force-pushed
the
kci-config-rework
branch
2 times, most recently
from
October 24, 2023 10:47
124e3e6 to
4a74841
Compare
gctucker
marked this pull request as draft
October 24, 2023 10:47
gctucker
force-pushed
the
kci-config-rework
branch
4 times, most recently
from
October 31, 2023 12:45
e14aad0 to
7fd5e0d
Compare
gctucker
marked this pull request as ready for review
October 31, 2023 12:46
gctucker
force-pushed
the
kci-config-rework
branch
from
November 1, 2023 16:46
7fd5e0d to
768508f
Compare
Collaborator
Author
|
Adding |
gctucker
force-pushed
the
kci-config-rework
branch
2 times, most recently
from
November 7, 2023 08:30
fd78d81 to
511b5bf
Compare
gctucker
removed
the
staging-skip
Implement `kci config` again with the new framework using Click and include a better way of dumping a particular section of the config with `kci config dump`. Enable `kci config validate` again in the Makefile test for YAML validation. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Remove the old `kci config` command implementation now that there's a replacement based on Click. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
gctucker
force-pushed
the
kci-config-rework
branch
from
November 7, 2023 09:00
511b5bf to
0b66bbe
Compare
gctucker
commented
Nov 8, 2023
gctucker
left a comment
gctucker
left a comment
Collaborator
Author
There was a problem hiding this comment.
Alright, we're back to "merge and fixup" mode due to lack of available reviewers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework
kci configwith the new command-line framework based on Click.Note: This doesn't implement
kci config setyet, it can be added as a follow-up.See the discussion about this command: kernelci/kernelci-project#263 (comment)