Skip to content

[fork/release/1.4] Add annotations to task update request api - #5

Merged
katiewasnothere merged 1 commit into
kevpar:fork/release/1.4from
katiewasnothere:fork_task_update_annotations
Nov 20, 2020
Merged

katiewasnothere merged 1 commit into
kevpar:fork/release/1.4from
katiewasnothere:fork_task_update_annotations

Conversation

@katiewasnothere

@katiewasnothere katiewasnothere commented Nov 20, 2020 •

Copy link
Copy Markdown
Collaborator

Original PR: containerd#4647

(cherry picked from commit 95ba6e9)
Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
(cherry picked from commit 95ba6e9)
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>

@dcantah dcantah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevpar

kevpar commented Nov 20, 2020

Copy link
Copy Markdown
Owner

We should update the title to make it clear this is a backport. How about [fork/release/1.4] prefixed?
A link to the original containerd/containerd PR would be good too.

@katiewasnothere

Copy link
Copy Markdown
Collaborator Author

[fork/release/1.4]

Ah, yes good point. I keep forgetting that part :p

@katiewasnothere katiewasnothere changed the title Add annotations to task update request api [fork/release/1.4] Add annotations to task update request api Nov 20, 2020
@katiewasnothere
katiewasnothere merged commit 9e80bf9 into kevpar:fork/release/1.4 Nov 20, 2020
@katiewasnothere
katiewasnothere deleted the fork_task_update_annotations branch November 20, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants