keybot: use system go for build jobs - #114
Open
chrisnojima wants to merge 1 commit into
Open
chrisnojima wants to merge 1 commit into
chrisnojima wants to merge 1 commit into
Conversation
Drop the custom /Users/build/code/go/bin prefix from the PATH handed to launchd build jobs. Homebrew's go (1.27.1) is now the one that gets used. /opt/homebrew/bin has to move ahead of /usr/local/bin: the build box has a stale golang.org pkg install at /usr/local/go symlinked into /usr/local/bin (1.23.1), which would otherwise win now that the explicit prefix is gone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MK1NyLj3PgQZxH343GEde
zoom-ua
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PATH handed to every launchd build job prepended
/Users/build/code/go/bin, pinning build jobs to a hand-built go (the comment just said "need custom go to fix issue"). This drops it so jobs use the system go./opt/homebrew/binalso has to move ahead of/usr/local/bin. The build box has:/opt/homebrew/bin/go— 1.27.1, maintained byscripts/upgrade.sh(brew upgrade go)/usr/local/bin/goand/usr/local/go/bin/go— 1.23.1, a stale golang.org pkg installHomebrew was last in the list, so simply deleting the prefix would have quietly downgraded build jobs to 1.23.1.
/usr/local/binis kept, just demoted below homebrew, since other tooling may live there.Verified with
go build ./...,go vet ./keybot/, andgo test ./keybot/ ./launchd/.Not included, but worth a follow-up:
keybot/keybase.keybot.plist(the bot's own plist, installed on the box by hand) has the same ordering, andkeybot/keybot.shrunsgo installunder it — so the keybot binary itself is currently built with 1.23.1. Alternatively, removing/usr/local/gofrom the box would drop the ordering trap entirely.🤖 Generated with Claude Code
https://claude.ai/code/session_018MK1NyLj3PgQZxH343GEde