Skip to content

Trying to append an event with wrong id results in UnknownError #344

Description

@Imanghvs

After calling appendToStream method with an id which is not a uuid, I get this error:

UnknownError: Could not recognize BadRequest

I was in situations where it took a long until I realized I was passing a wrong id through my app. I suggest having a validator on input, so we don't send such requests to EventStore at all (instead we can throw something like InvalidIdException.

I really like to make a PR for id validation, along with related tests if everyone agrees on such a fix.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions