Skip to content

appendToStream with expectedRevision -1 causes cryptic error #348

Open

Description

@rmp613

Describe the bug
Very similar to
kurrent-io/KurrentDB#2781

I get
Request message serialization failure: Cannot read property 'lo' of null
when attempting to appendToStream with -1 expectedRevision
To Reproduce
Steps to reproduce the behavior:

  1. call appendToStream with -1 expectedRevision

Expected behavior
A less cryptic error so the user can fix the issue

Actual behavior
A cryptic grpc error is thrown

Config/Logs/Screenshots

EventStore details

  • EventStore server version:
    23.10.0
  • Operating system:
    linux
  • EventStore client version (if applicable):
    6.0.0
    Additional context

DB-492

Activity

  1. rmp613 commented on Nov 7, 2023

    @rmp613
    Author
  2. alexeyzimarev commented on Nov 14, 2023

    @alexeyzimarev
    Member

    The current version of NodeJS client doesn't allow setting -1 as the expected revision, cloud you clarify what you are actually doing? Also, server version 6.0.0 is confusing as it doesn't exist.

  3. riordanpawley commented on Nov 14, 2023

    @riordanpawley

    The current version of NodeJS client doesn't allow setting -1 as the expected revision, cloud you clarify what you are actually doing? Also, server version 6.0.0 is confusing as it doesn't exist.

    Thanks for moving it, I forgot sorry.
    Client version 6.0.0. Server version 23.10.0
    I understand -1 is not a valid input but the types allow it and the error thrown is very hard to debug as an end user of the library.

  4. w1am commented on Nov 15, 2023

    @w1am
    Collaborator

    @riordanpawley This issue is already being addressed in this pull request #349

  5. riordanpawley commented on Nov 15, 2023

    @riordanpawley

    @riordanpawley This issue is already being addressed in this pull request #349

    OK Happy to close then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugIssues which are a software defect

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions