TwinsAutoOp: fix edit user config popup

[ctrlaltca]

fix #32

[erisfreenet]

Would this also fix the issue where persons that I "Registered &Add Auto Op" would sometimes be opped and sometimes not?
Thank you for your very fast response time. I've been looking for someone to fix that script for ages.

[ctrlaltca]

Would this also fix the issue where persons that I "Registered &Add Auto Op" would sometimes be opped and sometimes not?

Nope.. I've reopened #32, please let's continue the discussion there

[erisfreenet]

I also noticed when I use Twins Auto Op to "Register &Add AutoOp" to a highlighted nick it will not capture the hostmask. What it does do is;
Flags Tab:
Registration name: nick
Channel: #channel" (The current channel I am in with the person being registered.)
NetMask: EFnet (Network I am currently on)
What to do: op, voice, ban. (Twins will check the correct box)
Masks Tab:
it records nothing here. No hostmasks or IPs.

I determined this by using the twins Edit user Config.

Step 1. I use the KVirc native Registration feature, it captures the persons hostmask or IP. (I checked using Registration edit registration)
Step 2. I scroll down to Twins, the option I see are Add Autoop, Autovoice, Autoban (register is no longer an option this is good because we already Registered the person)
Step 3. I open Twins Edit user config, the menu pops up, I click on the Masks tab and find NO hostmasks or IPs were captured.

Hope this isn't confusing, If you want me to try another way, let me know.

[erisfreenet]

Sorry I just noticed something else. I add the hostmask or IP manually to Twins/edit user config and click OK. I go back in and check my manual addition, it did not save the hostmask I manual entry.

[erisfreenet]

Another issue, I add new user to Twins auto op when I do that I see Twins oping persons in my auto op list. Almost as if I clicked on Twins Check User Now.

[ctrlaltca]

About the user mask tab in the "edit user config": it's not a comprehensive list of the user masks associated with that specific user.
TwinsAutoOp internally uses kvirc's registered users database, so the masks are registered there (Settings -> configure registered users).
From the mask tab in the "edit user config" you can add new masks, that will be saved inside kvirc's registered user database, but you can't edit or delete already existing user masks.

[ctrlaltca]

Another issue, I add new user to Twins auto op when I do that I see Twins oping persons in my auto op list. Almost as if I clicked on Twins Check User Now.

I can confirm this. At the end of twins::autoop::set::user there's a call to twins::autoop::core::load -a that forces the reload of all channels/users and calls twins::autoop::check -q, triggering the autoop everywhere.
I think this was its supposed behavior, but to avoid that it-s a simple change in https://github.com/kvirc/kvirc-scripts/blob/master/twinsautoop/src/aliases.kvs#L347

-twins::autoop::core::load -a
+twins::autoop::core::load -a -n

[erisfreenet]

About the user mask tab in the "edit user config": it's not a comprehensive list of the user masks associated with that specific user. TwinsAutoOp internally uses kvirc's registered users database, so the masks are registered there (Settings -> configure registered users). From the mask tab in the "edit user config" you can add new masks, that will be saved inside kvirc's registered user database, but you can't edit or delete already existing user masks.

So, it's okay that Twins Auto OP Edit user Masks tab is empty because Twins utilizes the KVirc native register user hostmasks to know who to autoOp. Is that correct?

I did my own testing.

I highlight a user that is not registered on my KVirc, I scroll down to twins, menu opens and I right click edit user config.
I click on the Mask tab and I see that Twins has captured the IP of the unregistered user and filled the Mask boxes.
If I use Twins to register this person and &autoOp when I go back to the Mask tab the Mask tab is now empty.
I check the KVirc register user - edit user and I see the user has been added to the database. So I guess this is actual by design.

Another issue, I add new user to Twins auto op when I do that I see Twins oping persons in my auto op list. Almost as if I clicked on Twins Check User Now.

I opened the Aliases.kvs and added the -n to this line twins::autoop::core::load -a -n.
I'm guessing it won't take effect until I close KVirc and reload it.

Thank you for your assistance on the Twins :)

Do you know of an Oper script for KVirc?

Also do you take donations for the work you do on KVirc?

[ctrlaltca]

So, it's okay that Twins Auto OP Edit user Masks tab is empty because Twins utilizes the KVirc native register user hostmasks to know who to autoOp. Is that correct?

Exactly

Do you know of an Oper script for KVirc?

Not really; all the scripts i know are inside this repository.

Also do you take donations for the work you do on KVirc?

Nope. Feel free to offer a meal or a beer to somebody who really needs it.

[erisfreenet]

Nope. Feel free to offer a meal or a beer to somebody who really needs it.

I will pay if forward somehow. :)

[erisfreenet]

-twins::autoop::core::load -a
+twins::autoop::core::load -a -n

I made the changes to my aliases.kvs using qedit, I rebooted, loaded KVirc and connect to my usual server and went into my normal channels. I added a user to Twin Auto Op and when I did that, others were opped.
I checked the aliases.kvs file and "twins::autoop::core::load -a -n" is still there. Was I suppose to make the changes a different way? Script editor perhaps?

[erisfreenet]

Here's another oddity. I click on a user, scroll down to Twins AutoOp/voice/ban, Twin's says Register and add AutoOp as if the user is not registered correct? I click on register and add AutoOp and I receive "usera already has an autoop on #channelb [*]. Yet Twins is not oping the person in the specific channel. I check the Twins user config and usera is in there as OP. I also tried the CHECK USER NOW and usera still remained unopped.

I just checked the native KVirc register a user, I check usera and he is not registered. Twins says he is and KVirc says he is not. Let me see what happens if I try to register usera via KVirc registration. Okay usera is now registered and when I check Twins Auto OP, the user shows registered.

So Twins Register and add AutoOp no longer registers the user to KVirc native user registration. I click on Twins "check user now" and the user immediately gets opped.

[erisfreenet]

Bump my update from 2 weeks ago.