Skip to content

deps_sync: temp link path can collide with a package file named '<x>.labelle-link' #809

Description

@apotema

Follow-up from Codex review on #802 (#674). deps_sync.stageFile hardlinks to <dest>.labelle-link and renames it over <dest>. If a package ships both x and a real file named x.labelle-link, and iteration visits the suffixed one first, staging x deletes the already-staged sibling. That leaves an incomplete stage until the next generate. The fix is to use a scratch path outside the mirrored namespace, e.g. a per-sync temp dir under deps/.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions