Repository navigation
chore: stale doc drift in backend codegen — v2 path is production, audio wiring IS called - #506
Conversation
…ion, audio/font wiring IS called) Doc/comment-only follow-up from the #386 audit. Corrects comments that now describe the opposite of what the code does — no behavior change, no golden/generated output moves, `zig build test` passes unchanged. - root.zig `detectV2ManifestName`: drop "PRODUCTION NO-OP TODAY" — the #472 P2 cutover shipped; detection is live and driven solely by the resolved backend package shipping `backend.manifest.v2.zon`. - root.zig `generate` call-site: replace the "production no-op today" sentence with the live-detection description. - codegen/blocks/asset_wiring.zig audio + font: replace the "SCAFFOLDING … NOT yet called" blocks with WIRED docs — both are called from buildSetupCode (loop.zig:107/108) and buildCallbackInitCode (callback.zig:95/96), gated on `.sound`/`.font` resources. - deps_linker.zig `stagesSdlGamepad`/`stagesAndroidGamepad`: document the enum arms as defensive dead code (every Backend tag is now external post-#386), citing the pinning tests by name. Refs #503 Claude-Session: https://claude.ai/code/session_017pW3ifKf9wgxNg4viy6okw
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates documentation comments across several files (asset_wiring.zig, deps_linker.zig, and root.zig) to reflect the completion of various scaffolding phases, including Phase 4 for audio and font wiring, Phase 6c for external providers, and Phase 2 for manifest v2 cutover. It also documents certain blocks of code as defensive dead code kept for future use. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
👮 Files not reviewed due to content moderation or server errors (3)
📝 Walkthrough
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Doc-accuracy follow-up from the #386 audit — corrects comments in the codegen sources that now say the opposite of what the code does. Comment-only: no goldens or generated output move;
zig build testpasses unchanged.Corrections
A.
src/root.zig—detectV2ManifestNamedocDropped the "PRODUCTION NO-OP TODAY … returns null on every real generate" paragraph. The #472 P2 cutover shipped: detection is live and driven solely by the resolved backend package shipping
backend.manifest.v2.zon(in-tree sokol + v2 fixtures ship one; fetched providers opt in per-repo). Now points at theMANIFEST_V2_GENERATE_CUTOVERtest and the §7 byte-identical anchor.B.
src/root.zig—generatecall-site commentReplaced the "production no-op today" sentence with a live-detection description (kept the load-bearing
requireManifestIfExternalnote untouched).C.
src/codegen/blocks/asset_wiring.zig— audio + font wiringReplaced both "SCAFFOLDING (Phase 4) … NOT yet called" blocks with WIRED docs. Both helpers are called from
buildSetupCode(loop.zig:107/108) andbuildCallbackInitCode(callback.zig:95/96), gated on.sound/.fontresources. Did not touch anyw.printliteral (bit-identical contract). Kept the still-accurate@hasDecl-guard paragraph on the font sibling.D.
src/deps_linker.zig—stagesSdlGamepad/stagesAndroidGamepadDocumented the
switch (cfg.backend)enum arms as defensive dead code: post-#386 everyBackendtag resolves to an external provider, soisExternal()is true for every config and the arms are unreachable — pinned by the "every built-in is now external" tests (cited by name, not line).Verification
zig build→ exit 0zig build test→ exit 0 (thefailed command:lines are intentional negative-test logs)git statusshows only the 3 comment files changed — no golden movedCloses #503
https://claude.ai/code/session_017pW3ifKf9wgxNg4viy6okw