Repository navigation
fix(examples): scripting-smoke pins labelle-scripting v0.2.1 — the Lua mirror - #658
Conversation
…a mirror lua.org went down today and took the Examples integration test with it, five runs straight: v0.2.0's manifest fetches lua-5.4.8.tar.gz from lua.org and nowhere else. labelle-scripting#61 moved the URL to a byte-identical mirror hosted as a release asset (content hash unchanged and verified, so builds are identical); v0.2.1 is v0.2.0 plus exactly that commit, cherry-picked, so this bump changes which server answers and nothing else. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014pbwN1ytAa8tctZMaTMjAk
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe scripting smoke workflow and example project now reference scripting plugin version ChangesScripting plugin update
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Line 398: Align all scripting dependency comments with v0.2.1: update the
comments at .github/workflows/ci.yml lines 372, 381, 398, and 424, change
.github/workflows/ci.yml line 402 to reference the GitHub Lua mirror instead of
lua.org, and update the corresponding comment in
examples/scripting-smoke/project.labelle line 44.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0159a320-4530-4adc-956d-46c0968e96d4
📒 Files selected for processing (2)
.github/workflows/ci.ymlexamples/scripting-smoke/project.labelle
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014pbwN1ytAa8tctZMaTMjAk
lua.org is down and the Examples integration test has failed five consecutive runs on its single-sourced
lua-5.4.8.tar.gzURL (see #656's checks).The chain: labelle-scripting#61 moved the URL to a byte-identical mirror (release asset;
zig fetchverified the same content hash, cross-checked against two independent distro mirrors).v0.2.1isv0.2.0+ exactly that cherry-picked commit — no code changes, so this example's API surface is untouched and builds are byte-identical.This PR's own Examples job is the proof: it fetches v0.2.1 and builds the declare tool through the mirror.
🤖 Generated with Claude Code
https://claude.ai/code/session_014pbwN1ytAa8tctZMaTMjAk
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit