Skip to content

chore(materials): validate zbgfx #181 API161 toolchain (#175) - #814

Merged
apotema merged 6 commits into
mainfrom
codex/175-zbgfx-consumer-ci
Sep 30, 2026
Merged

apotema merged 6 commits into
mainfrom
codex/175-zbgfx-consumer-ci

Conversation

@apotema

@apotema apotema commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Validate the zbgfx ProgramVK stale-binding fix through the existing consumer CI, as required by the owner in RFC #172 comment 5904952568. All three consumer drafts use the identical archive URL and Zig package hash:

Tracks labelle-toolkit/labelle-bgfx#175 and RFC labelle-toolkit/labelle-bgfx#172. This is a temporary validation pin, not a release. Keep this PR draft and unmerged until the fork fixes have exact-head peer approval, the consumer CI gate passes, zbgfx is released, and this pin is replaced with the released tag/hash and retested. No CI workflow changes.

Local validation: package fetched successfully with Zig 0.16; pin URL/hash changes pass git diff --check. Full consumer CI pending. API142 material_shaderc remains unchanged in the assembler draft.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Chores
    • Updated the package release metadata and refreshed the underlying graphics build baseline.
    • The supported API and shader profile remain unchanged; this update does not alter user-facing functionality.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 55bf5b1d-f143-4b2d-b41b-56a3d7217c8b

📥 Commits

Reviewing files that changed from the base of the PR and between c2cba3d and aa6d6f4.

📒 Files selected for processing (2)
  • build.zig.zon
  • src/material_schema.zig

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The package version changed from 0.107.0 to 0.122.0. The API 161 toolchain now fetches the zbgfx v0.12.0 tag archive with an updated hash. Its GLSL profile and API remain unchanged.

Changes

Version updates

Layer / File(s) Summary
Package and toolchain version updates
build.zig.zon, src/material_schema.zig
The package version changed to 0.122.0. toolchain_api161 now uses the zbgfx v0.12.0 tag archive and its corresponding hash.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to aa6d6

The release pin is intentional, and no actionable merge-blocking defect remains. Merge after normal build and CI checks pass.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: validating the zbgfx API161 toolchain. This matches the package and toolchain updates described in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


A rabbit checks the version line,
Then tags a zbgfx archive fine.
The hash is set, the profile stays,
The API keeps its old ways.
I hop along through tidy changes.

Comment @coderabbitai help to get the list of available commands.

@apotema
apotema marked this pull request as ready for review September 30, 2026 16:38
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T16:42:02.767052Z aa6d6f4 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@apotema

apotema commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

VERDICT: APPROVED
Reviewed head: aa6d6f4ebd159344742275933c0bffc936cc553b. Reviewer: Claude (Anthropic LLM).

Findings (none blocking)

  • src/material_schema.zig:68-69: toolchain_api161 is …/zbgfx/archive/refs/tags/v0.12.0.tar.gz with hash zbgfx-0.12.0-Sm4IxDDnDAdy4wEOQlNiR2cdlwJtc7kx-MaMgwbCG5C_, which equals the release exactly. The tag resolves to 84fcf670…, and zig fetch reproduces the hash.
  • The only other zbgfx pin is toolchain_api142 at src/material_schema.zig:57-58 (934372f…). That is the intentional legacy toolchain for labelle-bgfx < 0.24.0, selected in material_pipeline.zig:65-68, so it is not stale. No eb71fd4 or Sm4IxN_KDAf reference remains.
  • Shader-blob compatibility: the GitHub compare eb71fd4…84fcf67 changes one file, libs/bgfx/src/renderer_vk.cpp, and nothing in shaderc. The compiled material blobs therefore stay byte-compatible with runtimes on either zbgfx, so there is no InvalidShader risk from this move.
  • Version: build.zig.zon:6 goes 0.107.0 → 0.122.0. gh release list shows v0.121.0 as Latest, so 0.122.0 is the correct next minor. The remaining 0.107.0 strings (src/cache/disk.zig:585, src/cache/plugin_subdir.zig:118-121) are historical test fixtures and comments.
  • Diff vs origin/main (c2cba3d, an ancestor of the head): git diff origin/main...HEAD touches only build.zig.zon and src/material_schema.zig (3 lines). Nothing unrelated slipped in.
  • Bots: CodeRabbit reviewed c2cba3d..aa6d6f4 and posted no actionable comments. There are no inline comments.

Ran (local, macOS arm64, Zig 0.16.0)

  • zig build test --summary all: exit 0 (checked directly, not piped). 94/94 steps, 3833/3849 tests passed, 16 skipped, 0 failed, 116 s.

CI at this head: build-and-test on ubuntu and macos, the Windows assembler suite, and Condenser under WebGL2 are all green.

@apotema
apotema merged commit 02993e2 into main Sep 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant