Skip to content

chore(materials): release assembler 0.122.1 with zbgfx 0.12.1 - #815

Merged
apotema merged 1 commit into
mainfrom
codex/178-zbgfx-consumer-release
Sep 30, 2026
Merged

apotema merged 1 commit into
mainfrom
codex/178-zbgfx-consumer-release

Conversation

@apotema

@apotema apotema commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Move API161 material_shaderc to released zbgfx v0.12.1 with the verified tag URL and package hash, and bump the assembler to 0.122.1. The legacy API142 pin is unchanged. No functional schema or API changes.

Validation: Windows Zig 0.16 zig build test -j2 --summary all exited 0: 94/94 steps, 3802/3849 tests passed (47 skipped). Claude approved exact head 3bd229c. Current-head CI must finish green before merge.

Release after backend 0.32.1 and ImGui 0.14.5, then update FP's released pins. Independent Windows/SM-T505 evidence covers the underlying #178 fix; #188/#190/#191 and FP#978 remain separate. No local dependency overrides or new CI jobs.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T22:48:47.720069Z 3bd229c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: aa3caede-7c22-499c-999b-69a40ab31296

📥 Commits

Reviewing files that changed from the base of the PR and between 02993e2 and 3bd229c.

📒 Files selected for processing (2)
  • build.zig.zon
  • src/material_schema.zig

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The package version changes from 0.122.0 to 0.122.1. toolchain_api161 uses the zbgfx v0.12.1 archive URL and matching hash instead of v0.12.0.

Changes

Release updates

Layer / File(s) Summary
Package version and toolchain archive
build.zig.zon, src/material_schema.zig
The package version changes to 0.122.1. toolchain_api161 uses the zbgfx v0.12.1 archive URL and matching hash.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 3bd22

The package version and API161 dependency pin are updated, and the archive hash is verified. No merge-blocking risk is evident; local consumer tests and current-head CI are still pending.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the assembler 0.122.1 release and the zbgfx 0.12.1 update, which are the main changes.
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


A rabbit checks the version line,
Then swaps the archive tag in time.
The matching hash is set in place,
One patch ahead in the build's pace.
The bunny hops, its work complete.

Comment @coderabbitai help to get the list of available commands.

@apotema

apotema commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

VERDICT: APPROVED

Reviewed head: 3bd229c65e344137e2566fe7e6dd911ae7c71895. Reviewer: Claude (Anthropic LLM).

  • Diff: 1 commit ahead of main, 0 behind. build.zig.zon (version) and src/material_schema.zig (the material_shaderc zbgfx pin; the legacy API142 toolchain pin stays as intended): .version → 0.122.1, and zbgfx → the v0.12.1 tag URL with hash zbgfx-0.12.1-Sm4IxFIADQeGBx-8Buqgluvv5HGD1vqGGPQF-utEsSac.
  • Hash: zig fetch of the v0.12.1 tag archive on macOS reproduces that exact hash.
  • No stale pins: git grep finds no v0.12.0 URL or hash left at this head.
  • Patch is the right bump: zbgfx v0.12.0..v0.12.1 is only feat: absorb backends, ecs adapters, and gui plugins from labelle-cli #7, the SUBOPTIMAL fix I approved with the SM-T505 A/B. It only touches renderer_vk.cpp, so there's no shader or API change.
  • Merge gate: green CI. Merge after the labelle-bgfx and ImGui releases.

@apotema
apotema merged commit 1bba56d into main Sep 30, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant