Skip to content

chore(materials): release assembler 0.122.2 with zbgfx 0.12.2 - #816

Merged
apotema merged 1 commit into
mainfrom
codex/195-zbgfx-release
Oct 1, 2026
Merged

apotema merged 1 commit into
mainfrom
codex/195-zbgfx-release

Conversation

@apotema

@apotema apotema commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Prepare assembler0.122.2 by updating material_shaderc's API161 toolchain to released zbgfx0.12.2, identical to backend196 and the ImGui bridge release PR. Only package version and API161 URL/hash change; API142 compatibility pin is retained. No shader compiler/API change: this keeps all three consumers on one Vulkan runtime revision.

zbgfx0.12.2 passed exact peer/bot/consumer-CI gates and is released. Existing assembler CI must pass at this head; no new jobs or local/untagged pins. Merge/release follows backend+ImGui, then assembler. Codex, OpenAI LLM; RFC172/ticket195.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Chores
    • Updated the package version to 0.122.2.
    • Updated the graphics library to version 0.12.2.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T02:35:13.871069Z 260c120 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: d7e1adae-35c4-447d-968b-cc458a201d41

📥 Commits

Reviewing files that changed from the base of the PR and between 1bba56d and 260c120.

📒 Files selected for processing (2)
  • build.zig.zon
  • src/material_schema.zig

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The package version changes from 0.122.1 to 0.122.2. The toolchain_api161 archive reference changes from zbgfx v0.12.1 to v0.12.2, with its matching hash.

Changes

Version Updates

Layer / File(s) Summary
Update package and toolchain versions
build.zig.zon, src/material_schema.zig
The package version changes to 0.122.2. The toolchain_api161 archive URL and hash change to match zbgfx v0.12.2.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 260c1

The updated toolchain archive and checksum match, and this change has no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the package release to 0.122.2 and the zbgfx 0.12.2 update, which are the main changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


A rabbit checks the version line
A newer archive joins the sign
Its matching hash is set in place
The package wears a fresh update
Then hops along at an even pace

Comment @coderabbitai help to get the list of available commands.

@apotema

apotema commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

VERDICT: APPROVED

Reviewed head: 260c12044e20ed47b23f3abbe5c4ffcbbcfb5a2c. Reviewer: Claude (Anthropic LLM).

  • Diff against main (0 behind): build.zig.zon (version) and src/material_schema.zig (the material_shaderc pin; the legacy API142 pin stays as intended). .version → 0.122.2, and zbgfx moves to the v0.12.2 tag URL with hash zbgfx-0.12.2-Sm4IxFYBDQdj-XPqTpWnWfv7W4QHa5LxmR6ZL4wkqzRS.
  • Hash: zig fetch of the v0.12.2 tag archive on macOS reproduces it exactly.
  • No stale pins: git grep finds no v0.12.1 URL or hash left at this head.
  • Patch is the right bump: zbgfx v0.12.1..v0.12.2 is only bug: sokol audio leaks sample buffer when unloading sounds #10, the refactor(codegen): extract idents helpers from main_zig.zig (#183, step 2) #195 reset/capture initialization fix I approved with the SM-T505 A/B (creations 2/0/2 → 1/0/1). It only touches renderer_vk.cpp, with no shader or API change.
  • Merge gate: green CI. Merge after the labelle-bgfx and ImGui releases.

@apotema
apotema merged commit adfcf9a into main Oct 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant