Skip to content

hooks: 8 remaining P2s from #420's last review passes (watch/replan, progress, wasm serve) #423

Closed

Description

@apotema

Codex findings on #420 after it used its three review-fix rounds (lifecycle hooks, now on development). All are P2. None blocks development, but each should be closed before development → main.

  • src/cli/pipeline.zig:1911 (e16ef85): Record WASM hook failures before terminal success
  • src/cli/pipeline.zig:195 (0004dc8): Prevent watched hooks from retriggering themselves
  • src/cli/pipeline.zig:1429 (0004dc8): Recheck the shader override after before-generate hooks
  • src/cli/pipeline.zig:1856 (0004dc8): Keep replanned provider storage alive through shutdown hooks
  • src/cli/pipeline.zig:631 (e89b93e): Refresh install state and lock when replanning providers
  • src/cli/progress.zig:351 (e89b93e): Clear compiler counters when reporting hook sub-steps
  • src/cli/pipeline.zig:1430 (e89b93e): Restore core progress details after before hooks
  • src/cli/pipeline.zig:1807 (e89b93e): Skip run hooks when a cross-target launch is skipped

Full text: the review comments on #420 at those commits. Part of #406.

https://claude.ai/code/session_01R2K5sJDL5Msn1uRTkybiDP

Activity

  1. apotema commented on Sep 26, 2026

    @apotema
    ContributorAuthor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions